Skip to content

Commit

Permalink
introduce firstHlc in HlcTracker
Browse files Browse the repository at this point in the history
Summary:
introduce firstHlc in HlcTracker. Ensure it is persisted on warm rolls and correctly updated through shard lifecycle changes:
1. shard subscription
2. shard dataloss
3. shard resubscription

The firstHlc will be used later in the stack (see D64814926) to identify items in cache that are not covered by the currently active wh subscription.
For more details, see: https://fburl.com/gdoc/3izqv6ei

Differential Revision: D64706643

fbshipit-source-id: 660d6bb6ffbb21a7c727f8590f63e74588eccd3d
  • Loading branch information
Shravya Yakkali authored and facebook-github-bot committed Nov 18, 2024
1 parent 499adf8 commit ecbddd5
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions mcrouter/lib/network/gen/Common.thrift
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ cpp.virtual
)
struct McVersionReply {
1: carbon_result.Result result
2: binary_5325 value
2: binary (cpp.type = "folly::IOBuf") value
3: string message
4: i16 appSpecificErrorCode
}(cpp.methods = "
Expand Down Expand Up @@ -251,6 +251,3 @@ struct GoAwayRequest {
",
cpp.virtual
)

// The following were automatically generated and may benefit from renaming.
typedef binary (cpp.type = "folly::IOBuf") binary_5325

0 comments on commit ecbddd5

Please sign in to comment.