Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master is broken because of missing include ClientIdentifierHelper.h #453

Closed
rnurgaliyev opened this issue Oct 24, 2024 · 1 comment
Closed

Comments

@rnurgaliyev
Copy link
Contributor

rnurgaliyev commented Oct 24, 2024

2f32271 added an include core_infra_security/thrift_authentication_module/detail/ClientIdentifierHelper.h in ServerOnRequest.h, which is probably internal to Facebook and not shipped anywhere.

sccache clang++-16 -DHAVE_CONFIG_H   -I..
-I/cfsetup_build/mcrouter/build/install/include
-DLIBMC_FBTRACE_DISABLE -DDISABLE_COMPRESSION
-Wno-missing-field-initializers -Wno-deprecated-declarations -W -Wall
-Wextra -Wno-unused-parameter -fno-strict-aliasing -std=c++20 -g -O2
-MT mcrouter-main.o -MD -MP -MF .deps/mcrouter-main.Tpo -c -o
mcrouter-main.o `test -f 'main.cpp' || echo './'`main.cpp
In file included from main.cpp:21:
In file included from ../mcrouter/StandaloneUtils.h:13:
In file included from ../mcrouter/Server.h:42:
In file included from ./Server-inl.h:23:
../mcrouter/ServerOnRequest.h:14:10: fatal error:
'core_infra_security/thrift_authentication_module/detail/ClientIdentifierHelper.h'
file not found
#include "core_infra_security/thrift_authentication_module/detail/ClientIdentifierHelper.h"
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[3]: *** [Makefile:2055: mcrouter-main.o] Error 1
@mszabo-wikia
Copy link
Contributor

I fixed this in #449 which also aims to generally make the build more stable. Unfortunately it seems to be stuck in something of a limbo right now.

facebook-github-bot pushed a commit to facebook/hhvm that referenced this issue Dec 19, 2024
Summary:
The OSS autotools build has been nonfunctional for about a year. While facebook/mcrouter#449 would be a better long-term approach to fixing the build since it would also bring it in sync with other Meta OSS projects and enable testing in CI, fixing the existing build until there's movement on that front would at least provide a signal on whether the OSS version is buildable at all.

So:
* Introduce new Ubuntu 24.04 build files and use them in CI. I'll remove build files, Dockerfiles etc. for ancient Ubuntu and CentOS versions in a followup PR.
* Pin fmtlib to 11.0.2, like fbcode_builder does, and skip building its test suite to not waste time.
* Use Ninja to generate and build CMake-based dependencies.
* Use googletest, gmock and zstd as packaged by Ubuntu rather than building their older versions from source.
* Introduce and use a new define `MCROUTER_OSS_BUILD` to mark OSS-specific conditional compilation blocks. This could probably replace the existing `LIBMC_FBTRACE_DISABLE` and `DISABLE_COMPRESSION` defines too, as long as those aren't used outside of the OSS build.
* Fix OSS build failures that have gone undetected due to CI being broken:
  * Add a shim for the SR-specific method `HostInfoLocation::hostUniqueKey` (used since 85facb9200dea75e661447ed11e05806f42de65f).
  * Remove redundant CarbonRouterInstance deletion logging that was using a Meta-specific include (used since 6c2142acd8e69edd40eed70a93ea17ee2909287d).
  * Disable client identity propagation in the OSS build since it relies on Meta-specific code (used since 2f32271533fdf54ce71cfb65f6fda3c621f076a4).

Fixes facebook/mcrouter#453, fixes facebook/mcrouter#444, fixes facebook/mcrouter#447 etc.

X-link: facebook/mcrouter#457

Reviewed By: lenar-f

Differential Revision: D67428119

Pulled By: disylh

fbshipit-source-id: a22e7616d9b82875611e45bf1df40a771db569d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants