-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Dockerfile for ubuntu 20.04 #437
base: main
Are you sure you want to change the base?
Conversation
Hi @filipenf! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
7be1d86
to
c6a2112
Compare
5b8aff2
to
147cc97
Compare
147cc97
to
01a96fa
Compare
Hi @filipenf Thansk for the docker file.
|
@bmm-alc yeah that makes sense, I'll look into pinning the version when I have some time |
Great ! thanks
…On Fri, Mar 29, 2024 at 1:27 AM Filipe Felisbino ***@***.***> wrote:
@bmm-alc <https://github.com/bmm-alc> yeah that makes sense, I'll look
into pinning the version when I have some time
—
Reply to this email directly, view it on GitHub
<#437 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATF2SCVQ7TJSYZUYXWHAEQTY2SYNPAVCNFSM6AAAAAA5ZPQDESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRWGM3TAMJXGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I tried building mcrouter using the existing dockerfile but it is not working with Ubuntu 20.04 currently - it seems others are facing similar issues: #413 and #411
To get it to work, I started a new dockerfile using multi-stage build so there's no need to run a clean-up at the end of the process, it also takes advantage of docker cache so builds are faster and removes the need for maintaining several scripts for install/cleanup
Please let me know if there's interest in getting this merged or if I'm on the wrong path :-)