adding the deploy step

.circleci/scripts/publish.sh → .github/scripts/publish.sh

@@ -4,17 +4,19 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# Reduce a semver tag name to a Metro's release branch naming convention, eg v0.1.2-alpha.3 -> 0.1.x
-RELEASE_BRANCH=$(echo "$CIRCLE_TAG" | awk -F. '{print substr($1, 2) "." $2 ".x"}')
-
-# Does a release branch contain this tag (hotfix workflow)
-TAG_ON_RELEASE_BRANCH=$(git branch -a --contains "$CIRCLE_TAG" | grep -cFx "  remotes/origin/$RELEASE_BRANCH" || true)
-echo "Tag is on release branch $RELEASE_BRANCH: $TAG_ON_RELEASE_BRANCH"
+# See https://github.com/facebook/metro/pull/1086 regarding handling of hotfix tags
 
 # Does main contain this tag (regular release workflow)
-TAG_ON_MAIN=$(git branch -a --contains "$CIRCLE_TAG" | grep -cFx '  remotes/origin/main' || true)
+TAG_ON_MAIN=$(git branch -a --contains "$RAW_TAG_NAME" | grep -cFx '  remotes/origin/main' || true)
 echo "Tag is on main branch: $TAG_ON_MAIN"
 
+# Deduce the expected name of a release branch for a tag based on Metro's release branch naming convention, eg v0.1.2-alpha.3 -> 0.1.x
+RELEASE_BRANCH=$(echo "$RAW_TAG_NAME" | awk -F. '{print substr($1, 2) "." $2 ".x"}')
+
+# Does a release branch contain this tag (hotfix workflow)
+TAG_ON_RELEASE_BRANCH=$(git branch -a --contains "$RAW_TAG_NAME" | grep -cFx "  remotes/origin/$RELEASE_BRANCH" || true)
+echo "Tag is on release branch $RELEASE_BRANCH: $TAG_ON_RELEASE_BRANCH"
+
 if [ $TAG_ON_RELEASE_BRANCH -eq $TAG_ON_MAIN ]; then
     echo "Could not determine whether this tag is 'latest' or a hotfix. Aborting."
     exit 1
@@ -25,4 +27,4 @@ NPM_TAG="latest"
 [ "$TAG_ON_RELEASE_BRANCH" -eq 1 ] && NPM_TAG="${RELEASE_BRANCH%.x}-stable"
 echo "Publishing with --tag=$NPM_TAG"
 
-npm run publish --tag="$NPM_TAG"
+npm run publish --tag="$NPM_TAG" --dry-run

.github/workflows/build-test-and-deploy.yml

@@ -0,0 +1,89 @@
+name: facebook/metro/build-test-and-deploy
+on:
+  workflow_call:
+  pull_request:
+    types: [opened, synchronize]
+  push:
+    tags:
+# The job is triggered for any tag push. Tag format validation will be done
+# as part of the deploy job for clearer error reporting on tag formatting
+      - '**'
+
+# head_ref is per PR, so this ensures that updating the latest PR commit
+# will cancel the previous run of the workflow and trigger a new one
+concurrency:
+  group: "build-test-and-deploy-${{ github.head_ref }}"
+  cancel-in-progress: true
+
+defaults:
+  run:
+    shell: bash
+
+jobs:
+  # run-js-checks:
+  #   runs-on: ubuntu-latest
+  #   name: "Typescript, Lint, Smoke Test"
+  #   steps:
+  #     - uses: actions/checkout@v4
+  #     - uses: ./.github/actions/yarn-install
+  #     - run: yarn typecheck
+  #     - run: yarn typecheck-ts
+  #     - run: yarn lint
+  #     - run: yarn test-smoke
+
+  # test-with-coverage:
+  #   runs-on: ubuntu-latest
+  #   name: "Test Coverage Calculation"
+  #   steps:
+  #   - uses: actions/checkout@v4
+  #   - uses: ./.github/actions/yarn-install
+  #   - run: yarn test-coverage
+  #   - run: "./.github/scripts/install_codecov.sh"
+  #   - run: "./codecov -t ${{ secrets.CODECOV_TOKEN }} -f ./coverage/coverage-final.json"
+
+  # test:
+  #   strategy:
+  #     matrix:
+  #       runs-on: ['ubuntu-latest'] # 'windows-latest'
+  #       node-version-type: ['lts', 'min-supported']
+  #   name: "Tests [${{ matrix.runs-on }} machine, ${{ matrix.node-version-type }} Node.js]"
+  #   runs-on: ${{ matrix.runs-on }}
+  #   steps:
+  #   - uses: actions/checkout@v4
+  #   - uses: ./.github/actions/yarn-install
+  #     with:
+  #       node-version-type: ${{ matrix.node-version-type }}
+  #   - name: Run Jest Tests
+  #     run: yarn jest --ci --maxWorkers 4 --reporters=default --reporters=jest-junit --rootdir='./'
+
+  validate-tag:
+    # runs only on tag pushes
+    if: ${{ github.ref_type == 'tag' }}
+    runs-on: ubuntu-latest
+    name: "Validate Tag For Deployment"
+    steps:
+    - uses: actions/github-script@v7
+      with:
+        script: |
+          if (/^v\d+(\.\d+){2}(-.*)?$/.test('${{ github.ref_name }}')) {
+            return true;
+          } else {
+            core.setFailed('ERROR! Wrong tag format failed the package deployment!');
+          }
+
+  deploy:
+    # runs only on tag pushes
+    if: ${{ github.ref_type == 'tag' }}
+    runs-on: ubuntu-latest
+    name: "Deploy"
+    # needs: [run-js-checks, test, validate-tag]
+    needs: [validate-tag]
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ./.github/actions/yarn-install
+      - run: echo "//registry.npmjs.org/:_authToken=${{ secrets.NPM_TOKEN }}" >> ~/.npmrc
+      - run: "./.github/scripts/publish.sh"
+        env:
+          RAW_TAG_NAME: ${{  github.ref_name }}
+      - run: rm ~/.npmrc
+