Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update docusaurus to 2.4.3 #1092

Closed
wants to merge 1 commit into from

Conversation

OzakIOne
Copy link
Contributor

@OzakIOne OzakIOne commented Oct 2, 2023

Summary

Upgrade docusaurus to 2.4.3

Test plan

CI Argos OzakIOne/metro-argos#1

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Oct 2, 2023
@facebook-github-bot
Copy link
Contributor

@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@robhogan
Copy link
Contributor

robhogan commented Oct 2, 2023

Huge thanks for this @OzakIOne! I'm pulling this in now.

I heard from @slorber that you initially looked into updating to v3 but ran into issues with our docusaurus-plugin-internaldocs-fb, which we use to integrate Docusaurus with internal search and previews. I'd love to help with that if I can - if you'd like, feel free to open a draft PR or issue with whatever's not working and I can take a look from our end.

@slorber
Copy link

slorber commented Oct 2, 2023

Thanks, I see.

We'll try to temporarily remove the usage of that package and see if we can make the site run. If it does, we can send a draft PR to upgrade to v3.

@facebook-github-bot
Copy link
Contributor

@robhogan merged this pull request in 3f8cfbf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants