Use resolvePackage instead of resolveModulePath in resolveHasteName
#1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1136 +/- ##
=======================================
Coverage 83.09% 83.09%
=======================================
Files 206 206
Lines 10549 10549
Branches 2619 2619
=======================================
Hits 8766 8766
Misses 1783 1783
☔ View full report in Codecov by Sentry. |
robhogan
approved these changes
Nov 15, 2023
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Thanks @kraenhansen - this LGTM (and @huntie), importing to run it through internal CI. FWIW, |
robhogan
pushed a commit
that referenced
this pull request
Jan 9, 2024
…ame` (#1136) Summary: This fixes #1128 by calling the `resolvePackage` instead of `resolveModulePath` in `resolveHasteName`. Only `resolvePackage` has the code to resolve package "exports" and it calls `resolveModulePath` as a fallback. Changelog: [Experimental] When enabled, the `"exports"` field is now considered for Haste packages (which could include local monorepo packages) Pull Request resolved: #1136 Test Plan: I've added a failing test which passed as the fix got implemented. Reviewed By: huntie Differential Revision: D51346769 Pulled By: robhogan fbshipit-source-id: 8a003d5b147b73d344365db7cff8187ff946013d
Merged
robhogan
pushed a commit
that referenced
this pull request
Jan 9, 2024
…ame` (#1136) Summary: This fixes #1128 by calling the `resolvePackage` instead of `resolveModulePath` in `resolveHasteName`. Only `resolvePackage` has the code to resolve package "exports" and it calls `resolveModulePath` as a fallback. Changelog: [Experimental] When enabled, the `"exports"` field is now considered for Haste packages (which could include local monorepo packages) Pull Request resolved: #1136 Test Plan: I've added a failing test which passed as the fix got implemented. Reviewed By: huntie Differential Revision: D51346769 Pulled By: robhogan fbshipit-source-id: 8a003d5b147b73d344365db7cff8187ff946013d
robhogan
pushed a commit
that referenced
this pull request
Jan 30, 2024
…ame` (#1136) Summary: This fixes #1128 by calling the `resolvePackage` instead of `resolveModulePath` in `resolveHasteName`. Only `resolvePackage` has the code to resolve package "exports" and it calls `resolveModulePath` as a fallback. Changelog: [Experimental] When enabled, the `"exports"` field is now considered for Haste packages (which could include local monorepo packages) Pull Request resolved: #1136 Test Plan: I've added a failing test which passed as the fix got implemented. Reviewed By: huntie Differential Revision: D51346769 Pulled By: robhogan fbshipit-source-id: 8a003d5b147b73d344365db7cff8187ff946013d
|
I'm wondering if we need to update the documentation based on this change 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #1128 by calling the
resolvePackageinstead ofresolveModulePathinresolveHasteName.Only
resolvePackagehas the code to resolve package "exports" and it callsresolveModulePathas a fallback.Test plan
I've added a failing test which passed as the fix got implemented.