Skip to content

Commit

Permalink
Remove exported OpenSSL dependency from DHKEM
Browse files Browse the repository at this point in the history
Summary:
D61632080 removes the OpenSSL usage from DHKEM internally, but it still left
the exported backend/OpenSSL header.

This diff removes the exported OpenSSL dependency from the target, and updates
callsites that were depending on this.

Reviewed By: zalecodez

Differential Revision: D62411511

fbshipit-source-id: fa41f2ceb42dd09999863ea3319160a0fbe3e57f
  • Loading branch information
Mingtao Yang authored and facebook-github-bot committed Sep 27, 2024
1 parent 135d7f3 commit 39ed684
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 19 deletions.
1 change: 1 addition & 0 deletions quic/fizz/client/handshake/test/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ cpp_unittest(
deps = [
"fbsource//third-party/googletest:gmock",
":mock_psk_cache",
"//fizz/backend:openssl",
"//fizz/client/test:mocks",
"//fizz/crypto/test:TestUtil",
"//fizz/protocol/clock/test:mock_clock",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
#include <condition_variable>
#include <mutex>

#include <fizz/backend/openssl/OpenSSL.h>
#include <fizz/client/test/Mocks.h>
#include <fizz/crypto/test/TestUtil.h>
#include <fizz/protocol/clock/test/Mocks.h>
Expand Down
39 changes: 20 additions & 19 deletions quic/samples/echo/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -13,25 +13,26 @@ mvfst_cpp_library(
"LogQuicStats.h",
],
exported_deps = [
"//fizz/compression:zlib_certificate_decompressor",
"//fizz/compression:zstd_certificate_decompressor",
"//folly:file_util",
"//folly:synchronized",
"//folly/fibers:core",
"//folly/io/async:scoped_event_base_thread",
"//quic:constants",
"//quic:exception",
"//quic/api:transport",
"//quic/client:client",
"//quic/codec:types",
"//quic/common:buf_util",
"//quic/common/events:folly_eventbase",
"//quic/common/test:test_client_utils",
"//quic/common/test:test_utils",
"//quic/common/udpsocket:folly_async_udp_socket",
"//quic/fizz/client/handshake:fizz_client_handshake",
"//quic/server:server",
"//quic/state:stats_callback",
"fbcode//fizz/backend:openssl",
"fbcode//fizz/compression:zlib_certificate_decompressor",
"fbcode//fizz/compression:zstd_certificate_decompressor",
"fbcode//folly:file_util",
"fbcode//folly:synchronized",
"fbcode//folly/fibers:core",
"fbcode//folly/io/async:scoped_event_base_thread",
"fbcode//quic:constants",
"fbcode//quic:exception",
"fbcode//quic/api:transport",
"fbcode//quic/client:client",
"fbcode//quic/codec:types",
"fbcode//quic/common:buf_util",
"fbcode//quic/common/events:folly_eventbase",
"fbcode//quic/common/test:test_client_utils",
"fbcode//quic/common/test:test_utils",
"fbcode//quic/common/udpsocket:folly_async_udp_socket",
"fbcode//quic/fizz/client/handshake:fizz_client_handshake",
"fbcode//quic/server:server",
"fbcode//quic/state:stats_callback",
],
exported_external_deps = [
"glog",
Expand Down
1 change: 1 addition & 0 deletions quic/samples/echo/EchoClient.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
#include <folly/fibers/Baton.h>
#include <folly/io/async/ScopedEventBaseThread.h>

#include <fizz/backend/openssl/OpenSSL.h>
#include <fizz/compression/ZlibCertificateDecompressor.h>
#include <fizz/compression/ZstdCertificateDecompressor.h>

Expand Down

0 comments on commit 39ed684

Please sign in to comment.