Add a transport setting to diable time based flow control updates

Summary: to experiment with Reviewed By: sharmafb Differential Revision: D60847248 fbshipit-source-id: 8e6b873331edfb87319e0758c6946461647c288f
facebook · Aug 7, 2024 · 6652c38 · 6652c38
1 parent 0801517
commit 6652c38
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/quic/flowcontrol/QuicFlowController.cpp b/quic/flowcontrol/QuicFlowController.cpp
@@ -34,7 +34,8 @@ Optional<uint64_t> calculateNewWindowUpdate(
       (updateTime - *lastSendTime) >
           transportSettings.flowControlRttFrequency * srtt;
   // If we are autotuning then frequent updates aren't required.
-  if (enoughTimeElapsed && !transportSettings.autotuneReceiveConnFlowControl) {
+  if (transportSettings.enableFlowControlTimeBasedUpdates &&
+      enoughTimeElapsed && !transportSettings.autotuneReceiveConnFlowControl) {
     return nextAdvertisedOffset;
   }
   bool enoughWindowElapsed = (curAdvertisedOffset - curReadOffset) *

diff --git a/quic/state/TransportSettings.h b/quic/state/TransportSettings.h
@@ -392,6 +392,9 @@ struct TransportSettings {
   bool enableWriterBackpressure{false};
   // Ack timeout = SRTT * ackTimerFactor
   double ackTimerFactor{kAckTimerFactor};
+  // If flow control updates should be sent based on time passed since last
+  // update.
+  bool enableFlowControlTimeBasedUpdates{true};
 };
 
 } // namespace quic