Remove temporary setting for rejecting quic key updates

Summary: This setting is no longer needed.

Reviewed By: mjoras

Differential Revision: D57112554

fbshipit-source-id: 4720dd864f24ac21a775419522254195c5ea215f

quic/api/QuicTransportFunctions.cpp

@@ -1946,10 +1946,6 @@ void updateOneRttWriteCipher(
 void maybeHandleIncomingKeyUpdate(QuicConnectionStateBase& conn) {
   if (conn.readCodec->getCurrentOneRttReadPhase() != conn.oneRttWritePhase) {
     // Peer has initiated a key update.
-    if (conn.transportSettings.rejectIncomingKeyUpdates) {
-      throw QuicTransportException(
-          "key update attempt rejected", TransportErrorCode::CRYPTO_ERROR);
-    }
     updateOneRttWriteCipher(
         conn,
         conn.handshakeLayer->getNextOneRttWriteCipher(),

quic/state/TransportSettings.h

@@ -361,10 +361,7 @@ struct TransportSettings {
       kFirstKeyUpdatePacketCount};
   // How many packets to send before initiating periodic key updates
   uint64_t keyUpdatePacketCountInterval{kDefaultKeyUpdatePacketCountInterval};
-  // Whether to terminate the connection when a peer initiates a key update.
-  // TODO: Remove this. This is a temporary measure to gradually roll out key
-  // update support.
-  bool rejectIncomingKeyUpdates{false};
+
   // Temporary flag to test new stream blocked condition.
   bool useNewStreamBlockedCondition{false};
   bool scheduleTimerForExcessWrites{false};