README: clarify what "optional" means #324
Conversation
Based on all the "should be implicitly optional and not warn without values" tests.
|
Hi @cben! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| @@ -65,7 +65,7 @@ class MyComponent extends React.Component { | |||
|
|
|||
| MyComponent.propTypes = { | |||
| // You can declare that a prop is a specific JS primitive. By default, these | |||
| // are all optional. | |||
| // are all optional - `undefined` and `null` are allowed. | |||
There was a problem hiding this comment.
in addition, they can be omitted entirely (which is distinct from being present but undefined). let's note that too!
Based on all the "should be implicitly optional and not warn without values" tests.