Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxygen For Windows #499

Open
bmarques1995 opened this issue May 17, 2024 · 0 comments
Open

Proxygen For Windows #499

bmarques1995 opened this issue May 17, 2024 · 0 comments
Assignees

Comments

@bmarques1995
Copy link
Contributor

The find program command in CMakeLists.txt is failing to find python on Windows

facebook-github-bot pushed a commit that referenced this issue Sep 18, 2024
Summary:
Added conditional verification to python executable to search for python instead of python3 on Windows.

This code without this modification is searching for python as python3.exe in Windows, but in the OS, python is installed as python.exe, what cause an incorrect python not found.

Issue: #499

Pull Request resolved: #500

Reviewed By: kvtsoy

Differential Revision: D62987053

Pulled By: afrind

fbshipit-source-id: fb21d711483b350d0b86b481cf876c95b82334e0
facebook-github-bot pushed a commit to facebook/hhvm that referenced this issue Sep 18, 2024
Summary:
Added conditional verification to python executable to search for python instead of python3 on Windows.

This code without this modification is searching for python as python3.exe in Windows, but in the OS, python is installed as python.exe, what cause an incorrect python not found.

Issue: facebook/proxygen#499

X-link: facebook/proxygen#500

Reviewed By: kvtsoy

Differential Revision: D62987053

Pulled By: afrind

fbshipit-source-id: fb21d711483b350d0b86b481cf876c95b82334e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants