Skip to content

Commit

Permalink
Guard invalid python annotations for 3.8 / 3.9 (#848)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #848

This is blocking an open source release.

Note: there's a test failure still in OSS in one of these tests.
We do need to fix that, but unlike using illegal-for-python-3.9
syntax it doesn't make Pyre unreleasable.

Reviewed By: connernilsen

Differential Revision: D57218457

fbshipit-source-id: 4691f2ef8be0f88effb9ce0a490d82e8fda2fa35
  • Loading branch information
stroxler authored and facebook-github-bot committed May 10, 2024
1 parent 05ba810 commit 267a8ce
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tools/upgrade/commands/configurationless.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@

# pyre-strict

from __future__ import annotations

import argparse
import json
import logging
Expand Down
1 change: 1 addition & 0 deletions tools/upgrade/commands/strict_default.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
strict_default contains a library for running a codemod across a codebase that turns pyre-strict on. Optionally, we can also remove the #pyre-strict and add #pyre-unsafe headers from files where the error count is below a certain threshhold.
"""

from __future__ import annotations

import argparse
import logging
Expand Down
1 change: 1 addition & 0 deletions tools/upgrade/configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
TODO(T132414938) Add a module-level docstring
"""

from __future__ import annotations

import glob
import json
Expand Down

0 comments on commit 267a8ce

Please sign in to comment.