This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
fix(backend): Match Profiler display name in react #1316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
React DevTools has been rewritten and recently launched a new version 4 UI 🎉 The source code for this rewrite was done in a separate repository and is being merged into the main React repo. Thank you for taking the time to contribute to this extension 🙇♂️ Because this PR is for the version code base, I am closing it. If you'd like to contribute to the new extension, please visit the new repository. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reconciles this fork with
shared/getComponentNameconcerningunstable_Profiler. Not including theidwas deliberate: facebook/react@9c990c2#r202042053Context:
Currently trying to implement
Profilerintoenzyme(enzymejs/enzyme#2055). It has an API to find certain components by display name (not saying that this is useful) and display the component tree. It's not obvious what the display name forunstable_Profilershould look like since the component stack trace inreactuses a different name thanreact-devtools.Since the devtools also include the props of the Profiler component it looks redundant to me to include it in the display name.
Didn't find any other location that might affect the display name. Need some guidance if this isn't enough.