Update linking.md #2802
Merged
Update linking.md #2802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Which" has probably been mistaken for "wish" but I think "want" is a better word. Either way, "which" is wrong in this sentence.
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
❌ Deploy Preview for react-native failed. 🔨 Explore the source changes: cc6d36c 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native/deploys/615ae1addc28e50007b77674 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Add closing tag for "queries" tag
Simek
approved these changes
Oct 7, 2021
There was a problem hiding this comment.
Hi @jenskuhrjorgensen, welcome to the community! 🙂
Thank you for catching this mistake and pushing the fix! 👍
sunnylqm
added a commit
to reactnativecn/react-native-website
that referenced
this pull request
Oct 9, 2021
* Add a note about where to place the Gradle vars (facebook#2776) Co-authored-by: Gijs Weterings <me@gijsweterings.nl> * Update appstate.md (facebook#2778) Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> * Animations: remove unused style object (facebook#2780) * Force `trim@^1.0.1` resolution (facebook#2782) * Bump axios from 0.21.1 to 0.21.4 (facebook#2783) Bumps [axios](https://github.com/axios/axios) from 0.21.1 to 0.21.4. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/master/CHANGELOG.md) - [Commits](axios/axios@v0.21.1...v0.21.4) --- updated-dependencies: - dependency-name: axios dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add help relating to Android intent queries (facebook#2774) * Add help relating to Android intent queries On Android 11 in order for `Linking.canOpenUrl` to return `true` the scheme/intent must be specified in AndroidManifest.xml and queryable. This is not currently clear in the documentation even though specific instructions are given for iOS. * Tweaks from prettier linting. * Fix spelling mistakes. Co-authored-by: Gijs Weterings <me@gijsweterings.nl> * Ensure AndroidManifest.xml example matches the descriptive text. Co-authored-by: Gijs Weterings <me@gijsweterings.nl> * Improve wording in the description for the example code. Co-authored-by: Gijs Weterings <me@gijsweterings.nl> * Split sentence in two to improve readability Co-authored-by: Gijs Weterings <me@gijsweterings.nl> Co-authored-by: Gijs Weterings <me@gijsweterings.nl> * docs: add fragment to native-components-android.md (facebook#2599) * docs: add fragment to native-components-android.md As a Javascript / React-Native developer I had a hard time figuring out how to integrate a custom native SDK to React Native with the help of Android Fragments. Please correct anything that you wish. This information took me 3 days to figure out, especially the part with `setupLayout` and `manuallyLayoutChildren` so I wish an example like this was available in the official documentation. I was expecting the code without `setupLayout` and `manuallyLayoutChildren` but i had no luck. If somebody has any better solution in your team, or any explanation, it would also be really nice to state in the documentation * chore: fix linting errors * chore: fix alex errors * docs: update native-components-android.md * docs: update native-components-android.md - add missing imports - remove extra spaces - remove unnecessary double cast - remove unnecessary comment * Bump semver-regex from 3.1.2 to 3.1.3 (facebook#2788) Bumps [semver-regex](https://github.com/sindresorhus/semver-regex) from 3.1.2 to 3.1.3. - [Release notes](https://github.com/sindresorhus/semver-regex/releases) - [Commits](https://github.com/sindresorhus/semver-regex/commits) --- updated-dependencies: - dependency-name: semver-regex dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump prismjs from 1.24.0 to 1.25.0 (facebook#2787) Bumps [prismjs](https://github.com/PrismJS/prism) from 1.24.0 to 1.25.0. - [Release notes](https://github.com/PrismJS/prism/releases) - [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md) - [Commits](PrismJS/prism@v1.24.0...v1.25.0) --- updated-dependencies: - dependency-name: prismjs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove the link to 2021 React Community Survey (facebook#2784) * Bump ansi-regex to ^5.0.1 to fix CVE-2021-3807 (facebook#2794) * Release 0.66 Post (facebook#2797) * Add post and assets * Fix lint * Update links and image * Ignore alex warning * Fix linking for highlights * Capitalize Bluetooth and align titles * Capitalize Bluetooth and align titles * Missed one Bluetooth * Credit mikehardy * Cut 0.66 docs (facebook#2798) * update link troubleshooting (facebook#2799) * Update handling-text-input.md (facebook#2795) * Update tsconfig.json example (facebook#2796) * fix preview deploy failure due to links in older blog posts (facebook#2803) * add section of `stickyHeaderHiddenOnScroll` option (facebook#2801) * Update native-modules-android.md (facebook#2791) * Update native-modules-android.md Those two methods are missing in the documentation and an exception is sent if they are not in the code. Co-authored-by: Simon BRUNOU <simon.brunou@bystamp.com> * Update linking.md (facebook#2802) * [Docs] Add an asterisk note to the hermes bundle is in use (facebook#2804) Co-authored-by: Raquel Smith <raquelmsmith@users.noreply.github.com> Co-authored-by: Gijs Weterings <me@gijsweterings.nl> Co-authored-by: Luis Durão <luis.p.durao@gmail.com> Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> Co-authored-by: Titus Efferian <kiritosato@gmail.com> Co-authored-by: Timothy Yung <yungsters@fb.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mike Leonard <mike.r.leonard@gmail.com> Co-authored-by: Fazekas Dániel <daniel.tamas.fazekas@gmail.com> Co-authored-by: Ivan Moskalev <ivan.moskalev@gmail.com> Co-authored-by: Nicola Corti <corti.nico@gmail.com> Co-authored-by: Luna <luwe@fb.com> Co-authored-by: Luis Medina Huerta <luism3861@gmail.com> Co-authored-by: Nana Asiedu-Ampem <nanaasiedu0@gmail.com> Co-authored-by: David NRB <4661784+retyui@users.noreply.github.com> Co-authored-by: guruguru-dekiruko <40130327+grgr-dkrk@users.noreply.github.com> Co-authored-by: Simon <5848809+simonbrunou@users.noreply.github.com> Co-authored-by: Simon BRUNOU <simon.brunou@bystamp.com> Co-authored-by: Jens Kuhr Jørgensen <jenskuhr4@gmail.com> Co-authored-by: limaAniceto <lima.aniceto@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Which" has probably been mistaken for "wish" but I think "want" is a better word. Either way, "which" is wrong in this sentence.