Fix the guide to the deprecated OpenJDK installation command. #2817

1natsu172 · 2021-10-19T11:55:06Z

The previous Brew installation command for adoptOpenJDK is now deprecated.

Followed the documentation and change the method to install Temurin.

facebook-github-bot · 2021-10-19T11:55:10Z

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

cortinico · 2021-10-19T12:00:43Z

I think we might want to prioritize bumping to JDK 11 first #2800

netlify · 2021-10-19T12:01:09Z

✔️ Deploy Preview for react-native ready!

🔨 Explore the source changes: 7b61f3e

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native/deploys/61fa40535015f300072da16a

😎 Browse the preview: https://deploy-preview-2817--react-native.netlify.app

facebook-github-bot · 2021-10-19T12:28:14Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

1natsu172 · 2021-10-19T12:32:04Z

@cortinico I've also changed this PR to the JDK11 command.

cortinico · 2021-10-19T16:17:37Z

👍 Still this is on hold till facebook/react-native#32186

Simek · 2021-10-19T16:40:14Z

Also this refs/duplicates #2800, but I'm not sure which PR includes the correct approach to the migration.

grgr-dkrk · 2021-10-20T01:36:17Z

This PR is a fix for the deprecation of AdoptOpenJDK/openjdk and does not seem to have anything to do with the #2800 fix.

I don't know when React Native will be updated to JDK11. Even if it's planned, it makes sense to change the description of homebrew tap which is already deprecated at this time.

Simek · 2021-10-20T07:16:44Z

This PR is a fix for the deprecation of AdoptOpenJDK/openjdk and does not seem to have anything to do with the #2800 fix.

I would argue, because the same lines are changed, and both PR awaits the merge of the same PR in main repo. 🙂

I don't know when React Native will be updated to JDK11.

Check out the link which Nicola posted. 😉

grgr-dkrk · 2021-10-20T10:01:17Z

Thanks. My concern is that adoptopenjdk/openjdk has been deprecated, not a JDK update.
In any case, I think the #2800 will need to be fixed as well. I apologize if I say something wrong.

1natsu172 · 2021-10-20T13:49:00Z

Whether it is JDK8 or JDK11, the Brew installation command has already been deprecated. See here for deprecation notices for previous commands.

The beginning of this PR, I submitted to fix the current JDK8 installation document, but Nicola wants to wait for 11, so I've modified the commit for JDK11.

#2800 has also changed the documentation for Choco on Windows, but the documentation for Brew on Mac remains a deprecated command.

If you accept this PR, please merge #2800 first, then merge this PR.

cortinico · 2021-10-22T15:47:08Z

The beginning of this PR, I submitted to fix the current JDK8 installation document, but Nicola wants to wait for 11, so I've modified the commit for JDK11.

I agree with the intention of migrating to the Temurin distribution. My point was more that we're in the process of migrating to JDK 11 (#2800). I'd suggest we merge #2800 first (as you @1natsu172 also suggested) and update the JDK afterwards distribution afterwards.

We know for sure that AdoptJDK works well with Android RN, and I would like to avoid introducing a JDK distribution change just before the bump to JDK 11.

cortinico · 2022-01-31T18:39:06Z

Reviving this PR as we're discussing it here reactwg/react-native-releases#13 (reply in thread)

@1natsu172 can I ask you to rebase and fix the merge conflict?

1natsu172 · 2022-02-01T17:57:30Z

@cortinico done for rebased and fixed conflict and applied to 0.67's guide.

cortinico

There is no need to update the versioned docs as this can be applied from the upcoming RN version on. I'd suggest to revert them

cortinico · 2022-02-01T18:41:52Z

docs/_getting-started-macos-android.md

@@ -19,10 +19,11 @@ If you have already installed Node on your system, make sure it is Node 12 or ne

 <h3>Java Development Kit</h3>

-We recommend installing JDK using [Homebrew](http://brew.sh/). Run the following commands in a Terminal after installing Homebrew:
+We recommend installing Temurin using [Homebrew](http://brew.sh/). Run the following commands in a Terminal after installing Homebrew:


Suggested change

We recommend installing Temurin using [Homebrew](http://brew.sh/). Run the following commands in a Terminal after installing Homebrew:

We recommend installing the OpenJDK distribution called Temurin using [Homebrew](http://brew.sh/). Run the following commands in a Terminal after installing Homebrew:

1natsu172 · 2022-02-02T08:28:24Z

@cortinico I resubmitted. Please review it.

kelset · 2022-02-02T11:08:27Z

@Simek this should be now ready to go 👍

* Generate 0.67 version of the docs (facebook#2926) * version 0.67 * Revert "version 0.67" This reverts commit f4896ac. * updated v0.67 docs cut * blogpost for 0.67 (facebook#2933) * add Lorenzo * Facebook -> Meta * 067 blogpost * add highlights and truncate * tweak * Update website/blog/2022-01-19-version-067.md * Update website/blog/2022-01-19-version-067.md Co-authored-by: Eli White <github@eli-white.com> * Move Hermes 0.10 issue callout to acknowledgements * Link the wiki Co-authored-by: Luna <lunaleaps@gmail.com> Co-authored-by: Eli White <github@eli-white.com> * blogpost: React Native - H2 2021 Recap (facebook#2937) Co-authored-by: Luna <luwe@fb.com> * Fix typo in H2 blog post: next year / half -> numbers (facebook#2938) * Use numbers for the time * Bump nanoid from 3.1.30 to 3.2.0 (facebook#2939) Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.30 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.1.30...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * remove text in running on device (facebook#2943) * remove text on docs running-on-device (facebook#2944) * Fix small grammatical error (facebook#2942) * update copyright on website (facebook#2940) Co-authored-by: luism3861 <Eduardo_Medina@fragua.com.mx> * Fix flexShrink default value in Layout Props docs (facebook#2945) * update website font, misc UI tweaks (facebook#2947) * Fix the guide to the deprecated OpenJDK installation command. (facebook#2817) * Add function based components example for Flat list optimisation (facebook#2955) * Update typo in render-pipeline.md (facebook#2951) * Update typo in tutorial.md (facebook#2946) * Add an extra command to the troubleshooting guide for typescript template (facebook#2954) Co-authored-by: Nicola Corti <corti.nico@gmail.com> * (Image) Fix documentation for onLoad event. (facebook#2964) * - (Image) Fix documentation for onLoad event. * - (Image) Prettier. * Update image.md (facebook#2965) * Bump follow-redirects from 1.14.7 to 1.14.8 (facebook#2966) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fixed a typo in Linking page. (facebook#2968) AndroidManifext.xml should be AndroidManifest.xml * 📚 Guide: Getting Started with The New Architecture (a.k.a. the Playbook) (facebook#2879) * Initial Draft of the New Architecture Playbook * Fix c++ codeblocks not rendering correctly * Fix Android.mk containing wrong wildcards * Remove Markdown exports artifacts * Fix missing parenthesis in section header * Renamed section header as it was incomplete * Removed canCreateTurboModule as it was not used * Fix indententation and add imports to MyComponentsRegistry.java * Add missing import for MyComponentsRegistry.h * Fix the broken table * s/two/three arguments * Fix comments inside podfile * split The New Architecture guide into few pages (facebook#2882) * Fix wrong import for ./RNTMyNativeViewNativeComponent * Fix import for codegenNativeCommands * Add a banner for TypeScript support * Do not sound prescriptive with 'you will be using flow' * React concurrent mode -> React 18 * Add a banner on homepage about the number of manual steps * Fix typo on Enabling TurboModule section title Co-authored-by: Johny Urgiles <jurgiles@users.noreply.github.com> * code formatting, admonitions and small tweaks (facebook#2922) Co-authored-by: Nicola Corti <corti.nico@gmail.com> * Use descriptive component names and fix use of ref (facebook#2935) * Use descriptive component names and fix use of ref * Remove ambiguity from migrating .measure* example * Playbook => Guide * Use implicit dependency substitution for the Gradle Plugin * Specify reactRoot and codegenDir in the App setup * Add a patch for configureNdkBuild not depending on preBuild * Add the getTurboModule method * Copy the warning banner on all the pages * Update pod install to specify RCT_NEW_ARCH_ENABLED * HermesExecutorFactory header lives inside reacthermes/ and not React/ * Fix broken jsExecutorFactoryForBridge iOS * Bump used nightly version to 0.0.0-20220201-2008-79975d146 * Clarify the react-native-codegen version to use * Suggest to use :app:externalNativeBuildDebug instead of Release * Put LOCAL_SHARED_LIBRARIES on Android.mk on separate lines * Update docs/new-architecture-app-renderer-ios.md Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> * Remove unnecessary duplicated `pod install` Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> * Setup a New Architecture Troubleshooting page * Fix lint failures on troubleshooting section Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> Co-authored-by: Johny Urgiles <jurgiles@users.noreply.github.com> Co-authored-by: Samuel Susla <samuel.susla@gmail.com> * fix(ios): update Fabric in Podfile instructions (facebook#2973) * fix(ios): update Fabric in Podfile instructions * move fabric_enabled comment closer to the property * 📚 Add instruction for M1 users to work with Cocoapods (facebook#2974) * Update Android SDK version to 30 (facebook#2975) * Adding Explain Like I'm 5 video to the home page (facebook#2971) * Adding ELI5 video to the home page * Remove unused VideoContainer function * Combining Video and Talk sections Co-authored-by: Dmitry Vinnik <dvinnik@fb.com> * Updated expired link in docs/security (facebook#2972) * Updated link colors to meet WCAG color contrast guidelines. (facebook#2976) * Bump prismjs from 1.25.0 to 1.27.0 (facebook#2978) Bumps [prismjs](https://github.com/PrismJS/prism) from 1.25.0 to 1.27.0. - [Release notes](https://github.com/PrismJS/prism/releases) - [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md) - [Commits](PrismJS/prism@v1.25.0...v1.27.0) --- updated-dependencies: - dependency-name: prismjs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: spelling error mudule -> module (facebook#2979) * Update migration guide feedback link to the working group (facebook#2983) * Add TOC sections for the 'Render, Commit, and Mount' page (facebook#2985) * Adding Social Banner in Support of Ukraine (facebook#2986) * fix layout resizing when page includes wide code block (facebook#2980) * docs: Moving to use Announcement Banner for the Support Ukraine Initiative (facebook#2988) * Fix deeplink to react-host-components-or-host-components in Glossary (facebook#2992) * Clarify intended audience for architecture overview (facebook#2995) * changed android_hyphenation for 0.67+ (facebook#2982) * Add missing `normal` enum for Hyphenation (facebook#3002) * add ToC headers for phases on Render Pipeline page (facebook#2997) * Moving Release Wiki to react-native-website (facebook#2961) Co-authored-by: Simek <gosimek@gmail.com> * Update discrete update threading model diagram (facebook#2999) * move Fabric warning to partial, use admonition (facebook#2998) * Clarify the Configure Codegen in your Gradle File section (facebook#2993) Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> * Unversion Architecture docs (facebook#3000) Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> * refactor(getting-started): path to sdk binaries (facebook#2991) * bump lint stack, include `website` files in check (facebook#3004) * Add table of contents and encourage people to leave feedback in working group in Architecture Overview intro (facebook#2996) * Clarify intended audience for architecture overview * Fix broken links * Blogpost: An update on the New Architecture Rollout (facebook#3009) Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> Co-authored-by: Lorenzo Sciandra <notkelset@kelset.dev> * Use bundler to pod install (facebook#3011) * Use placeholders instead of hardcoded strings (facebook#3015) * Use @flow annotation and fix syntax (facebook#3016) * Improve documentation about JS Specs (facebook#3017) * Use more specific dependency React-Core (facebook#3020) * distinguish windows from mac keytool instructions (facebook#3019) Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> * spelling fix (facebook#3021) * Rename _bridge into bridge (facebook#3013) * Use empty dicts instead of nil (facebook#3014) * 📚 Rename JSCExecutorFactory into HermesExecutorFactory (facebook#3012) * fix codegenNativeCommands section example (facebook#3024) Co-authored-by: Piotr Trocki <piotr@trocki.com> * [sync-api] Replace deprecated String.prototype.substr() (facebook#3025) * Add kotlin sample code in "Integration with an Android Fragment" documentation (facebook#2977) Co-authored-by: Andrei Shikov <andreiishikov@gmail.com> Co-authored-by: Nicola Corti <corti.nico@gmail.com> Co-authored-by: Simek <gosimek@gmail.com> * small custom CSS fixes and tweaks (facebook#3026) * Update references from Java to Java/Kotlin in the body of the article (facebook#3028) Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> * update project structure in Readme (facebook#3031) Co-authored-by: Lorenzo Sciandra <notkelset@kelset.dev> Co-authored-by: Luna <lunaleaps@gmail.com> Co-authored-by: Eli White <github@eli-white.com> Co-authored-by: Nicola Corti <ncor@fb.com> Co-authored-by: Luna <luwe@fb.com> Co-authored-by: Sota <5866096+sota000@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Luis Medina Huerta <luism3861@gmail.com> Co-authored-by: Palash Shrivastava <35087196+BattleOfPlassey@users.noreply.github.com> Co-authored-by: Michael Evans <michaelrevans@live.co.uk> Co-authored-by: luism3861 <Eduardo_Medina@fragua.com.mx> Co-authored-by: jzxchiang1 <15524484+jzxchiang1@users.noreply.github.com> Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> Co-authored-by: 1natsu <1natsu172@users.noreply.github.com> Co-authored-by: DIBYAJYOTI MISHRA <dibyajyotimishra14@gmail.com> Co-authored-by: Jiovanna Manriquez <jiovannamanriquez@gmail.com> Co-authored-by: markbell2410 <24226636+markbell2410@users.noreply.github.com> Co-authored-by: Nicola Corti <corti.nico@gmail.com> Co-authored-by: Erick Maeda Lopes <erick.maeda26@gmail.com> Co-authored-by: Kavanaugh Latiolais <kav@pelo.tech> Co-authored-by: hj <jiehecd@gmail.com> Co-authored-by: Johny Urgiles <jurgiles@users.noreply.github.com> Co-authored-by: Samuel Susla <samuel.susla@gmail.com> Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com> Co-authored-by: Riccardo <riccardo.cipolleschi@gmail.com> Co-authored-by: Kid <44045911+kidonng@users.noreply.github.com> Co-authored-by: Dmitry Vinnik <dmitryvinn@users.noreply.github.com> Co-authored-by: Dmitry Vinnik <dvinnik@fb.com> Co-authored-by: Vishwa Gaurav <81325730+VishwaGauravIn@users.noreply.github.com> Co-authored-by: blavalla <blavalla@gmail.com> Co-authored-by: RayKay91 <61206305+RayKay91@users.noreply.github.com> Co-authored-by: zegermouw <zegermouw@gmail.com> Co-authored-by: Nicolas <nicolashortaadam@gmail.com> Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com> Co-authored-by: Henry Hobhouse <henryhobhouse@gmail.com> Co-authored-by: Samuel Susla <samuelsusla@fb.com> Co-authored-by: Danilo Bürger <info@danilobuerger.de> Co-authored-by: Riccardo <cipolleschi@fb.com> Co-authored-by: Fernando Cervera <86963649+fernandocervera-abi@users.noreply.github.com> Co-authored-by: Rajesh Sharma <broncha@rajesharma.com> Co-authored-by: troZee <12766071+troZee@users.noreply.github.com> Co-authored-by: Piotr Trocki <piotr@trocki.com> Co-authored-by: CommanderRoot <CommanderRoot@users.noreply.github.com> Co-authored-by: David Vacca <515103+mdvacca@users.noreply.github.com> Co-authored-by: Andrei Shikov <andreiishikov@gmail.com>

1natsu172 marked this pull request as ready for review October 19, 2021 12:06

facebook-github-bot added the CLA Signed label Oct 19, 2021

Simek added 🕐 Waiting on PR These may be waiting for a PR to the facebook/react-native to be merged Wait on future Release This indicates a PR that updates the doc to match a future release. labels Oct 19, 2021

cortinico reviewed Feb 1, 2022

View reviewed changes

fix(docs): change jdk distro to temurin

7b61f3e

1natsu172 force-pushed the patch-2 branch from 749b166 to 7b61f3e Compare February 2, 2022 08:26

cortinico approved these changes Feb 2, 2022

View reviewed changes

cortinico merged commit b675091 into facebook:main Feb 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the guide to the deprecated OpenJDK installation command. #2817

Fix the guide to the deprecated OpenJDK installation command. #2817

1natsu172 commented Oct 19, 2021 •

edited

Loading

facebook-github-bot commented Oct 19, 2021

cortinico commented Oct 19, 2021

netlify bot commented Oct 19, 2021 •

edited

Loading

facebook-github-bot commented Oct 19, 2021

1natsu172 commented Oct 19, 2021

cortinico commented Oct 19, 2021

Simek commented Oct 19, 2021 •

edited

Loading

grgr-dkrk commented Oct 20, 2021

Simek commented Oct 20, 2021 •

edited

Loading

grgr-dkrk commented Oct 20, 2021 •

edited

Loading

1natsu172 commented Oct 20, 2021

cortinico commented Oct 22, 2021

cortinico commented Jan 31, 2022

1natsu172 commented Feb 1, 2022

cortinico left a comment

cortinico Feb 1, 2022

1natsu172 commented Feb 2, 2022

kelset commented Feb 2, 2022

	We recommend installing Temurin using [Homebrew](http://brew.sh/). Run the following commands in a Terminal after installing Homebrew:
	We recommend installing the OpenJDK distribution called Temurin using [Homebrew](http://brew.sh/). Run the following commands in a Terminal after installing Homebrew:

Fix the guide to the deprecated OpenJDK installation command. #2817

Fix the guide to the deprecated OpenJDK installation command. #2817

Conversation

1natsu172 commented Oct 19, 2021 • edited Loading

facebook-github-bot commented Oct 19, 2021

Action Required

Process

cortinico commented Oct 19, 2021

netlify bot commented Oct 19, 2021 • edited Loading

facebook-github-bot commented Oct 19, 2021

1natsu172 commented Oct 19, 2021

cortinico commented Oct 19, 2021

Simek commented Oct 19, 2021 • edited Loading

grgr-dkrk commented Oct 20, 2021

Simek commented Oct 20, 2021 • edited Loading

grgr-dkrk commented Oct 20, 2021 • edited Loading

1natsu172 commented Oct 20, 2021

cortinico commented Oct 22, 2021

cortinico commented Jan 31, 2022

1natsu172 commented Feb 1, 2022

cortinico left a comment

Choose a reason for hiding this comment

cortinico Feb 1, 2022

Choose a reason for hiding this comment

1natsu172 commented Feb 2, 2022

kelset commented Feb 2, 2022

1natsu172 commented Oct 19, 2021 •

edited

Loading

netlify bot commented Oct 19, 2021 •

edited

Loading

Simek commented Oct 19, 2021 •

edited

Loading

Simek commented Oct 20, 2021 •

edited

Loading

grgr-dkrk commented Oct 20, 2021 •

edited

Loading