-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Documentation] updating documentation for accessible and accessibilityRole="link" prop #3226
Open
fabOnReact
wants to merge
5
commits into
facebook:main
Choose a base branch
from
fabOnReact:accessible-prop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
>Sometimes this will group's descendants that are also marked as accessible together into one focusable element (e.g. accessible with accessible descendants), and sometimes it does not (e.g. accessible with accessible descendants). >It's definitely worth clarifying this behavior in the documentation facebook/react-native#30851 (comment) facebook/react-native#30851 (comment) facebook/react-native#30851 (comment) >On iOS the default behavior (and really, the only reasonably possible behavior), would be that the outer view is focusable, and must be given an accessibilityLabel to describe it. No accessible element can have accessible descendants, and all accessible elements must have an accessibility label. Apple has has this very straightforward, and easy to understand for developers. >Google on the other hand, has made things quite a bit more complicated. >On Android, the default behavior in this situation would be that all three views (the outer View and the inner two Text views) would attempt to become focusable (assume that the accessible prop maps to Androids focusable view property), but in this case the outer view would actually need some sort of label to be provided, as it has no content that it could announce. If no label was given, the outer view would become unfocusable and only the inner views would end up being focusable, which is exactly what you are seeing happen with the "Nested Text Views" example. If a label was given (and this label was mapped to the contentDescription property), then all three views would become focusable. - [x] [prepare documentation PR clarifying differences between iOS and Android](facebook/react-native#30851 (comment)) for scenarios [accessible parent view and one not accessible child](facebook/react-native#30851 (comment)) and [parent view with accessibilityLabel does not over-ride children with onPress handler](facebook/react-native#30851 (comment)) - [ ] iOS documentation for [Nested Text is not accessible](facebook/react-native#30851 (comment))
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
fabOnReact
changed the title
screenreader difference in behaviour between TalkBack and VoiceOver
[documentation] screenreader difference in behaviour between TalkBack and VoiceOver
Jul 27, 2022
fabOnReact
changed the title
[documentation] screenreader difference in behaviour between TalkBack and VoiceOver
[Documentation] screenreader difference in behaviour between TalkBack and VoiceOver
Jul 27, 2022
fabOnReact
changed the title
[Documentation] screenreader difference in behaviour between TalkBack and VoiceOver
[Documentation] screenreader difference in behaviour of accessible prop between TalkBack and VoiceOver
Jul 27, 2022
…ested Text Components with accessibilityRole="link" or inline Images facebook/react-native#30850 (comment) <details><summary>Nested Test with accessibilityRole="link" is accessible when parent sets importantForAccessibility="yes"</summary> <p> https://github.com/facebook/react-native/pull/33215/files#diff-37199b6b562523b453547e7fb56c95fd9aed5dc01fee3f6bdd50e97297ff8e7fR78 https://developer.android.com/reference/android/view/View#IMPORTANT_FOR_ACCESSIBILITY_YES facebook/react-native#30375 (comment) <details><summary>sourcecode of the example</summary> <p> ```javascript class AccessibilityExample extends React.Component<{}> { render(): React.Node { const uri = 'https://portfoliofabrizio.s3.eu-central-1.amazonaws.com/videos/surfcheck-poster.png'; return ( <View> <RNTesterBlock title="TextView without label"> <Text importantForAccessibility="no" accessible={true}> This is a Text with an Image as nested Child and a Link. <Text accessibilityRole="link"> This is a link </Text> <Image accessible={true} focusable={true} importantForAccessibility="yes" accessibilityLabel="image accessibilityLabel" source={{uri}} style={{height: 400, width: 200}} /> </Text> </RNTesterBlock> </View> ); } } ``` </p> </details> <video src="https://user-images.githubusercontent.com/24992535/180412450-071467b1-41ca-4818-b8cc-cbe966b65859.mp4" width="1000" /> </p> </details> <details><summary>Nested Test with accessibilityRole="link" is **not** accessible when parent sets importantForAccessibility="no"</summary> <p> <video src="https://user-images.githubusercontent.com/24992535/180390384-62129561-5d80-417b-8146-15acee128f76.mp4" width="1000" /> </p> </details> <details><summary>ExploreByTouchHelper#requestAccessibiltyFocus</summary> <p> https://github.com/aosp-mirror/platform_frameworks_base/blob/19e53cfdc8a5c6ef45c0adf2dd239576ddce5822/core/java/com/android/internal/widget/ExploreByTouchHelper.java#L595 ```java /** * Attempts to give accessibility focus to a virtual view. * <p> * A virtual view will not actually take focus if * {@link AccessibilityManager#isEnabled()} returns false, * {@link AccessibilityManager#isTouchExplorationEnabled()} returns false, * or the view already has accessibility focus. * * @param virtualViewId The id of the virtual view on which to place * accessibility focus. * @return Whether this virtual view actually took accessibility focus. */ private boolean requestAccessibilityFocus(int virtualViewId) { final AccessibilityManager accessibilityManager = (AccessibilityManager) mContext.getSystemService(Context.ACCESSIBILITY_SERVICE); if (!mManager.isEnabled() || !accessibilityManager.isTouchExplorationEnabled()) { return false; } // TODO: Check virtual view visibility. if (!isAccessibilityFocused(virtualViewId)) { // Clear focus from the previously focused view, if applicable. if (mFocusedVirtualViewId != INVALID_ID) { sendEventForVirtualView(mFocusedVirtualViewId, AccessibilityEvent.TYPE_VIEW_ACCESSIBILITY_FOCUS_CLEARED); } // Set focus on the new view. mFocusedVirtualViewId = virtualViewId; // TODO: Only invalidate virtual view bounds. mView.invalidate(); sendEventForVirtualView(virtualViewId, AccessibilityEvent.TYPE_VIEW_ACCESSIBILITY_FOCUSED); return true; } return false; } ``` </p> </details> <details><summary>View#onFocusChanged</summary> <p> https://github.com/aosp-mirror/platform_frameworks_base/blob/19e53cfdc8a5c6ef45c0adf2dd239576ddce5822/core/java/android/view/View.java#L12837 ```java /** * Called by the view system when the focus state of this view changes. * When the focus change event is caused by directional navigation, direction * and previouslyFocusedRect provide insight into where the focus is coming from. * When overriding, be sure to call up through to the super class so that * the standard focus handling will occur. * * @param gainFocus True if the View has focus; false otherwise. * @param direction The direction focus has moved when requestFocus() * is called to give this view focus. Values are * {@link #FOCUS_UP}, {@link #FOCUS_DOWN}, {@link #FOCUS_LEFT}, * {@link #FOCUS_RIGHT}, {@link #FOCUS_FORWARD}, or {@link #FOCUS_BACKWARD}. * It may not always apply, in which case use the default. * @param previouslyFocusedRect The rectangle, in this view's coordinate * system, of the previously focused view. If applicable, this will be * passed in as finer grained information about where the focus is coming * from (in addition to direction). Will be <code>null</code> otherwise. */ @callsuper protected void onFocusChanged(boolean gainFocus, @FocusDirection int direction, @nullable Rect previouslyFocusedRect) { if (gainFocus) { sendAccessibilityEvent(AccessibilityEvent.TYPE_VIEW_FOCUSED); } else { notifyViewAccessibilityStateChangedIfNeeded( AccessibilityEvent.CONTENT_CHANGE_TYPE_UNDEFINED); } // Here we check whether we still need the default focus highlight, and switch it on/off. switchDefaultFocusHighlight(); if (!gainFocus) { if (isPressed()) { setPressed(false); } if (hasWindowFocus()) { notifyFocusChangeToImeFocusController(false /* hasFocus */); } onFocusLost(); } else if (hasWindowFocus()) { notifyFocusChangeToImeFocusController(true /* hasFocus */); } invalidate(true); ListenerInfo li = mListenerInfo; if (li != null && li.mOnFocusChangeListener != null) { li.mOnFocusChangeListener.onFocusChange(this, gainFocus); } if (mAttachInfo != null) { mAttachInfo.mKeyDispatchState.reset(this); } if (mParent != null) { mParent.onDescendantUnbufferedRequested(); } notifyEnterOrExitForAutoFillIfNeeded(gainFocus); } ``` </p> </details> <details><summary>View#findAccessibilityFocusHost</summary> <p> ```java /** * Returns the view within this view's hierarchy that is hosting * accessibility focus. * * @param searchDescendants whether to search for focus in descendant views * @return the view hosting accessibility focus, or {@code null} */ private View findAccessibilityFocusHost(boolean searchDescendants) { if (isAccessibilityFocusedViewOrHost()) { return this; } if (searchDescendants) { final ViewRootImpl viewRoot = getViewRootImpl(); if (viewRoot != null) { final View focusHost = viewRoot.getAccessibilityFocusedHost(); if (focusHost != null && ViewRootImpl.isViewDescendantOf(focusHost, this)) { return focusHost; } } } return null; } ``` </p> </details>
fabOnReact
changed the title
[Documentation] screenreader difference in behaviour of accessible prop between TalkBack and VoiceOver
[Documentation] updating documentation for accessible and accessibilityRole="link" prop
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
screenreader difference in behaviour of accessible prop between TalkBack and VoiceOver
facebook/react-native#30851 (comment) facebook/react-native#30851 (comment) facebook/react-native#30851 (comment)
fixes facebook/react-native#30851
importantForAccessibility="no" does not allow screenreader focus on nested Text Components with accessibilityRole="link" or inline Images
Nested Test with accessibilityRole="link" is accessible when parent sets importantForAccessibility="yes"
https://github.com/facebook/react-native/pull/33215/files#diff-37199b6b562523b453547e7fb56c95fd9aed5dc01fee3f6bdd50e97297ff8e7fR78
https://developer.android.com/reference/android/view/View#IMPORTANT_FOR_ACCESSIBILITY_YES
facebook/react-native#30375 (comment)
sourcecode of the example
edited.copy.mp4
Nested Test with accessibilityRole="link" is **not** accessible when parent sets importantForAccessibility="no"
2022-07-22.15-47-18.mp4
fixes facebook/react-native#30850 (comment)