Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _getting-started-macos-android.md #4156

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

iGroza
Copy link

@iGroza iGroza commented Jul 7, 2024

Description

This pull request updates the instructions for setting up the JAVA_HOME environment variable in the _getting-started-macos-android.md file to reflect the use of Zulu JDK 17.

Changes Made

• Updated the JAVA_HOME path from Library/Java/JavaVirtualMachines/zulu-17.jdk/Contents/Home to /usr/libexec/java_home -v 17.
• This change ensures compatibility with the latest Zulu JDK 17 installation paths.

Additional Information

This update aims to simplify the setup process for developers and ensure consistency with the latest JDK distributions.

@facebook-github-bot
Copy link

Hi @iGroza!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copy link

netlify bot commented Jul 7, 2024

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 8ad0c5d
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/670f9cc1f7a933000874e6a7
😎 Deploy Preview https://deploy-preview-4156--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the versioned docs?

@@ -33,7 +33,7 @@ After the JDK installation, add or update your `JAVA_HOME` environment variable
If you used above steps, JDK will likely be located at `/Library/Java/JavaVirtualMachines/zulu-17.jdk/Contents/Home`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to be updated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still relevant

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@@ -33,7 +33,7 @@ After the JDK installation, add or update your `JAVA_HOME` environment variable
If you used above steps, JDK will likely be located at `/Library/Java/JavaVirtualMachines/zulu-17.jdk/Contents/Home`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants