Skip to content

Commit

Permalink
Accept node arguments when iOS app is built (#22423)
Browse files Browse the repository at this point in the history 
Summary:
Fixes #22421

If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.

_Pull requests that expand test coverage are more likely to get reviewed. Add a test case whenever possible!_
Pull Request resolved: #22423

Differential Revision: D13287099

Pulled By: TheSavior

fbshipit-source-id: e4ac0fb930107dde092541fd17d4c81907c8cc34
  • Loading branch information
@Kuchitama @facebook-github-bot
Kuchitama authored and facebook-github-bot committed Dec 1, 2018
1 parent 757518e commit 003dbaa
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion scripts/react-native-xcode.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ fi

[ -z "$NODE_BINARY" ] && export NODE_BINARY="node"

[ -z "$NODE_ARGS" ] && export NODE_ARGS=""

[ -z "$CLI_PATH" ] && export CLI_PATH="$REACT_NATIVE_DIR/local-cli/cli.js"

[ -z "$BUNDLE_COMMAND" ] && BUNDLE_COMMAND="bundle"
Expand All @@ -106,7 +108,7 @@ type "$NODE_BINARY" >/dev/null 2>&1 || nodejs_not_found

BUNDLE_FILE="$DEST/main.jsbundle"

"$NODE_BINARY" "$CLI_PATH" $BUNDLE_COMMAND \
"$NODE_BINARY" $NODE_ARGS "$CLI_PATH" $BUNDLE_COMMAND \
$CONFIG_ARG \
--entry-file "$ENTRY_FILE" \
--platform ios \
Expand Down

1 comment on commit 003dbaa

@sachinB94
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, is this not release yet ? Because I'm on 0.57.8, and I don't see these changes.

Please sign in to comment.