chore: Address pr comments

facebook · Oct 4, 2022 · 01159df · 01159df
1 parent 243b1c5
commit 01159df
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/ReactCommon/hermes/inspector/tools/run_msggen b/ReactCommon/hermes/inspector/tools/run_msggen
@@ -3,7 +3,7 @@
 set -e
 
 ROOT=$(pwd)
-pushd $ROOT >/dev/null || exit
+pushd $ROOT >/dev/null
 
 DIR=$(cd -P "$(dirname "$(readlink "${BASH_SOURCE[0]}" || echo "${BASH_SOURCE[0]}")")" && pwd)
 
@@ -15,8 +15,8 @@ FBSOURCE=$(hg root)
 CLANG_FORMAT="${FBSOURCE}/tools/third-party/clang-format/clang-format"
 SIGNEDSOURCE="${FBSOURCE}/tools/signedsource"
 
-popd >/dev/null || exit
-cd "packages/hermes-inspector-msggen"
+popd >/dev/null
+pushd "${ROOT}/packages/hermes-inspector-msggen"
 
 yarn install
 yarn build
@@ -32,3 +32,5 @@ node bin/index.js \
 
 "${SIGNEDSOURCE}" sign "${HEADER_PATH}"
 "${SIGNEDSOURCE}" sign "${CPP_PATH}"
+
+popd >/dev/null