Skip to content

Commit

Permalink
Rollout enableCloseVisibleGapBetweenPaths
Browse files Browse the repository at this point in the history
Summary:
This has been fully rolled out internally.

Changelog: [Fixed] Rolls out rounded view rendering improvements introduced in D39979567

Reviewed By: NickGerleman

Differential Revision: D50641814

fbshipit-source-id: 8e4dc470ca8716444c5bd88ae0e76754dc7acf37
  • Loading branch information
javache authored and facebook-github-bot committed Nov 1, 2023
1 parent ecffc4d commit 2856299
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -106,12 +106,6 @@ public class ReactFeatureFlags {
*/
public static boolean enableRemoveDeleteTreeInstruction = false;

/**
* Allow closing the small gap that appears between paths when drawing a rounded View with a
* border.
*/
public static boolean enableCloseVisibleGapBetweenPaths = true;

/**
* Allow fix in layout animation to drop delete...create mutations which could cause missing view
* state in Fabric SurfaceMountingManager.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import android.view.View;
import androidx.annotation.Nullable;
import com.facebook.react.common.annotations.VisibleForTesting;
import com.facebook.react.config.ReactFeatureFlags;
import com.facebook.react.modules.i18nmanager.I18nUtil;
import com.facebook.react.uimanager.FloatUtil;
import com.facebook.react.uimanager.Spacing;
Expand Down Expand Up @@ -110,8 +109,7 @@ private enum BorderStyle {
// such as between the mBackgroundColorRenderPath and its border.
// The smallest amount (found to be 0.8f) is used to extend
// the paths, overlapping them and closing the visible gap.
private final float mGapBetweenPaths =
ReactFeatureFlags.enableCloseVisibleGapBetweenPaths ? 0.8f : 0.0f;
private final float mGapBetweenPaths = 0.8f;

private @Nullable float[] mBorderCornerRadii;
private final Context mContext;
Expand Down

0 comments on commit 2856299

Please sign in to comment.