Skip to content

Commit

Permalink
fix: update executor for packages publishing workflow (#36146)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #36146

Changelog: [Internal]

- While working on 0.71.3, it was discovered that `react-native-codegen` package is being published almost empty (without `lib` folder)
- The reason for it is that `prepare` script is not being executed
- The main reason for it is npm v6, which requires adding `unsafe-perm` flag for it: https://www.vinayraghu.com/blog/npm-unsafe-perm
- Instead of using this flag, changing executor to `nodelts`, which has node v18 and npm v8
- Also adding `run_yarn` before running the script, because `react-native/codegen` uses external dependencies (such as rimraf) for its build scripts

Reviewed By: cipolleschi

Differential Revision: D43248175

fbshipit-source-id: d12b93decbf408713e309fe8be75d8d5ec994868
  • Loading branch information
hoxyq authored and facebook-github-bot committed Feb 14, 2023
1 parent 0d82b40 commit 28d8f25
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1537,9 +1537,10 @@ jobs:
echo "Nightly build run"
find_and_publish_bumped_packages:
executor: reactnativeandroid
executor: nodelts
steps:
- checkout
- run_yarn
- run:
name: Set NPM auth token
command: echo "//registry.npmjs.org/:_authToken=${CIRCLE_NPM_TOKEN}" > ~/.npmrc
Expand Down

0 comments on commit 28d8f25

Please sign in to comment.