Skip to content

Commit

Permalink
Fix Apple TV compile errors
Browse files Browse the repository at this point in the history
Summary:
Apple TV compilation is currently broken in master -- this fixes it.

Existing tests will pass after this change.
Closes #14652

Differential Revision: D5295021

Pulled By: javache

fbshipit-source-id: 8b4b0db0afa1caeacac0ad01abbed80fa7e39738
  • Loading branch information
douglowder authored and facebook-github-bot committed Jun 21, 2017
1 parent 1199592 commit 31fe832
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
6 changes: 4 additions & 2 deletions React/Modules/RCTDeviceInfo.m
Original file line number Diff line number Diff line change
Expand Up @@ -93,14 +93,14 @@ - (void)didReceiveNewContentSizeMultiplier
});
}

#if !TARGET_OS_TV

- (void)interfaceOrientationDidChange
{
#if !TARGET_OS_TV
__weak typeof(self) weakSelf = self;
RCTExecuteOnMainQueue(^{
[weakSelf _interfaceOrientationDidChange];
});
#endif
}


Expand All @@ -123,5 +123,7 @@ - (void)_interfaceOrientationDidChange
_currentInterfaceOrientation = nextOrientation;
}

#endif // TARGET_OS_TV


@end
4 changes: 2 additions & 2 deletions React/Modules/RCTUIManager.h
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,8 @@ RCT_EXTERN NSString *const RCTUIManagerRootViewKey;
- (void)rootViewForReactTag:(NSNumber *)reactTag withCompletion:(void (^)(UIView *view))completion;

/**
* Finds a view that is tagged with {@param nativeId} as its nativeID prop
* with the associated {@param rootTag} root tag view hierarchy. Returns the
* Finds a view that is tagged with nativeID as its nativeID prop
* with the associated rootTag root tag view hierarchy. Returns the
* view if found, nil otherwise.
*
* @param nativeID the id reference to native component relative to root view.
Expand Down

1 comment on commit 31fe832

@amorenew
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there will be android tv support in the future like apple tv?

Please sign in to comment.