address review

facebook · Jun 11, 2024 · 41d97fb · 41d97fb
1 parent 7aa145c
commit 41d97fb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/...es/react-native/ReactCommon/react/renderer/components/scrollview/ScrollViewShadowNode.cpp b/...es/react-native/ReactCommon/react/renderer/components/scrollview/ScrollViewShadowNode.cpp
@@ -64,10 +64,12 @@ void ScrollViewShadowNode::layout(LayoutContext layoutContext) {
 }
 
 Point ScrollViewShadowNode::getContentOriginOffset(
-    bool /* includeTransform */) const {
-
+    bool includeTransform) const {
   auto stateData = getStateData();
   auto contentOffset = stateData.contentOffset;
-  return {-contentOffset.x, -contentOffset.y + stateData.scrollAwayPaddingTop};
+  auto transform = includeTransform ? getTransform() : Transform::Identity();
+  auto result = transform * Vector{-contentOffset.x, -contentOffset.y, 0, 1};
+
+  return {result.x, result.y + stateData.scrollAwayPaddingTop};
 }
 } // namespace facebook::react
diff --git a/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp b/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp
@@ -193,7 +193,7 @@ Transform LayoutableShadowNode::getTransform() const {
 }
 
 Point LayoutableShadowNode::getContentOriginOffset(
-    bool /*includeTransform*/) const {
+    bool includeTransform) const {
   return {0, 0};
 }