Issue #16159 - RCTImageStoreManager's priority

Summary: RCTImageStoreManager and RCTBlobManager have the same priority, hence in certain cases, both are able to handle the request, but this causes non-deterministic behavior. Hence increased ImageStoreManager's Priority to 1 and thereby increasing RCTImageLoader's Priority to 2 to prevent similar issue of same priorities. Issue: #16159 Closes #16160 Differential Revision: D6017931 Pulled By: shergin fbshipit-source-id: 91f2737af4f2f97197734b696105e1cdc5683365
facebook · Oct 10, 2017 · 4e5d50d · 4e5d50d
1 parent dbe6044
commit 4e5d50d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/Libraries/Image/RCTImageLoader.m b/Libraries/Image/RCTImageLoader.m
@@ -66,7 +66,7 @@ - (void)setUp
 
 - (float)handlerPriority
 {
-    return 1;
+    return 2;
 }
 
 - (id<RCTImageCache>)imageCache

diff --git a/Libraries/Image/RCTImageStoreManager.m b/Libraries/Image/RCTImageStoreManager.m
@@ -32,6 +32,11 @@ @implementation RCTImageStoreManager
 
 RCT_EXPORT_MODULE()
 
+- (float)handlerPriority
+{
+    return 1;
+}
+
 - (void)removeImageForTag:(NSString *)imageTag withBlock:(void (^)())block
 {
   dispatch_async(_methodQueue, ^{