Skip to content

Commit

Permalink
refactor(bump-all-updated-packages): use tag instead of custom commit…
Browse files Browse the repository at this point in the history
… name
  • Loading branch information
hoxyq committed Feb 20, 2023
1 parent f8d8764 commit 72bfae8
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 8 deletions.
19 changes: 17 additions & 2 deletions scripts/monorepo/bump-all-updated-packages/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,13 @@
*/

const chalk = require('chalk');
const {execSync} = require('child_process');
const inquirer = require('inquirer');
const path = require('path');
const {echo, exec, exit} = require('shelljs');
const yargs = require('yargs');

const {BUMP_COMMIT_MESSAGE} = require('../constants');
const {PUBLISH_PACKAGES_TAG} = require('../constants');
const forEachPackage = require('../for-each-package');
const checkForGitChanges = require('../check-for-git-changes');
const bumpPackageVersion = require('./bump-package-version');
Expand Down Expand Up @@ -167,7 +168,21 @@ const main = async () => {
return;
}

exec(`git commit -a -m "${BUMP_COMMIT_MESSAGE}"`, {cwd: ROOT_LOCATION});
// exec from shelljs currently does not support interactive input
// https://github.com/shelljs/shelljs/wiki/FAQ#running-interactive-programs-with-exec
execSync('git commit -a', {cwd: ROOT_LOCATION, stdio: 'inherit'});

const enteredCommitMessage = exec('git log -n 1 --format=format:%B', {
cwd: ROOT_LOCATION,
silent: true,
}).stdout.trim();
const commitMessageWithTag =
enteredCommitMessage + `\n\n${PUBLISH_PACKAGES_TAG}`;

exec(`git commit --amend -m "${commitMessageWithTag}"`, {
cwd: ROOT_LOCATION,
silent: true,
});
})
.then(() => echo());
}
Expand Down
4 changes: 2 additions & 2 deletions scripts/monorepo/constants.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@
* @format
*/

const BUMP_COMMIT_MESSAGE = '[ci][monorepo] bump package versions';
const PUBLISH_PACKAGES_TAG = '@publish-packages-to-npm';

module.exports = {BUMP_COMMIT_MESSAGE};
module.exports = {PUBLISH_PACKAGES_TAG};
8 changes: 4 additions & 4 deletions scripts/monorepo/find-and-publish-all-bumped-packages.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
const path = require('path');
const {spawnSync} = require('child_process');

const {BUMP_COMMIT_MESSAGE} = require('./constants');
const {PUBLISH_PACKAGES_TAG} = require('./constants');
const forEachPackage = require('./for-each-package');

const ROOT_LOCATION = path.join(__dirname, '..', '..');
Expand Down Expand Up @@ -79,10 +79,10 @@ const findAndPublishAllBumpedPackages = () => {
process.exit(1);
}

const hasSpecificCommitMessage =
commitMessage.startsWith(BUMP_COMMIT_MESSAGE);
const hasSpecificPublishTag =
commitMessage.includes(PUBLISH_PACKAGES_TAG);

if (!hasSpecificCommitMessage) {
if (!hasSpecificPublishTag) {
throw new Error(
`Package ${packageManifest.name} was updated, but not through CI script`,
);
Expand Down

0 comments on commit 72bfae8

Please sign in to comment.