Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix for crash when height or width is nil (#20454)
Summary: This PR fixes the issue of height/width being nil in line no 128 of RCTImagePickerManager.m . ` [self _dismissPicker:picker args:tempImageTag ? @[tempImageTag, height, width] : nil]; ` Fixes#20411 Test Plan ---------- To verify the fix , please make the changes to make either height, width or both `nil ` in `- (void)imagePickerController:(UIImagePickerController *)picker didFinishPickingMediaWithInfo:(NSDictionary<NSString *, id> *)info` function of RCTImagePickerManager.m , run the code , you will see the error saying , one of the argument is nil from the array . ![crashscenario](https://user-images.githubusercontent.com/763696/43397014-133ae8fc-9421-11e8-9730-c5906cb8dbea.png) ![crashhandledscenario](https://user-images.githubusercontent.com/763696/43397012-130e42f2-9421-11e8-80fc-cb1abaf8197c.png) Now run the code with the fix , it will not crash . Release Notes: -------------- [IOS][BUGFIX][RCTImagePickerManager] - Change in RCTImagePickerManager to handle crashes if height/width is nil . Pull Request resolved: #20454 Differential Revision: D9061059 Pulled By: hramos fbshipit-source-id: b17f58e411f97f9b904cca0de6c151312c732972
- Loading branch information