Skip to content

Commit

Permalink
Clean up: remove eslint-disable no-undef in test_js* scripts
Browse files Browse the repository at this point in the history
Summary: Changelog: [Internal] - Clean up - Remove `eslint-disable no-undef` by not requiring `shelljs/global`

Reviewed By: cortinico

Differential Revision: D33197964

fbshipit-source-id: 2e36fc10bf4e3230b8ae914f48d244446da43973
  • Loading branch information
Luna Wei authored and facebook-github-bot committed Dec 21, 2021
1 parent 8d652fb commit 8583d39
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
5 changes: 1 addition & 4 deletions scripts/run-ci-e2e-tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,8 @@
* --skip-cli-install - to skip react-native-cli global installation (for local debugging)
* --retries [num] - how many times to retry possible flaky commands: yarn add and running tests, default 1
*/
/*eslint-disable no-undef */
require('shelljs/global');

const {cd, cp, echo, exec, exit, mv} = require('shelljs');
const spawn = require('child_process').spawn;
const argv = require('yargs').argv;
const path = require('path');
Expand Down Expand Up @@ -288,5 +287,3 @@ try {
}
}
exit(exitCode);

/*eslint-enable no-undef */
5 changes: 1 addition & 4 deletions scripts/run-ci-javascript-tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,8 @@
* --jestBinary [path] - path to jest binary, defaults to local node modules
* --yarnBinary [path] - path to yarn binary, defaults to yarn
*/
/*eslint-disable no-undef */
require('shelljs/global');

const {echo, exec, exit} = require('shelljs');
const argv = require('yargs').argv;

const numberOfMaxWorkers = argv.maxWorkers || 1;
Expand Down Expand Up @@ -72,5 +71,3 @@ try {
echo('Finished.');
}
exit(exitCode);

/*eslint-enable no-undef */

0 comments on commit 8583d39

Please sign in to comment.