Skip to content

Commit

Permalink
Rename analyticsTag -> internal_analyticsTag in ImageView component
Browse files Browse the repository at this point in the history
Summary:
This diff renames the analyticsTag prop for the intenral_analyticsTag in ImageView component

changelog: [internal] Creation of internal_analyticTag prop in ImageView, for now this prop is meant to be used internally.

Reviewed By: TheSavior

Differential Revision: D20904497

fbshipit-source-id: 2a28f746772ee0f9d657ec71549020c1f3e9d674
  • Loading branch information
mdvacca authored and facebook-github-bot committed Apr 8, 2020
1 parent 22e318f commit 8e48dc0
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions Libraries/Image/Image.android.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ const ImageProps = {
/**
* Analytics Tag used by this Image
*/
analyticTag: PropTypes.string,
internal_analyticTag: PropTypes.string,
/**
* Invoked on load start
*/
Expand Down Expand Up @@ -299,7 +299,7 @@ let Image = (props: ImagePropsType, forwardedRef) => {
analyticTag !== null
? {
...nativeProps,
analyticTag: analyticTag,
internal_analyticTag: analyticTag,
}
: nativeProps;
return (
Expand Down
4 changes: 2 additions & 2 deletions Libraries/Image/ImageProps.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ export type ImageProps = {|
accessible?: ?boolean,

/**
* Analytics Tag used by this Image
* Internal prop to set an "Analytics Tag" that can will be set on the Image
*/
analyticTag?: ?string,
internal_analyticTag?: ?string,

/**
* The text that's read by the screen reader when the user interacts with
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,8 @@ public void setBlurRadius(ReactImageView view, float blurRadius) {
view.setBlurRadius(blurRadius);
}

@ReactProp(name = "analyticTag")
public void setAnalyticsTag(ReactImageView view, @Nullable String analyticTag) {
@ReactProp(name = "internal_analyticTag")
public void setInternal_AnalyticsTag(ReactImageView view, @Nullable String analyticTag) {
if (mCallerContextFactory != null) {
view.updateCallerContext(
mCallerContextFactory.getOrCreateCallerContext(
Expand Down

0 comments on commit 8e48dc0

Please sign in to comment.