Skip to content

Commit

Permalink
Update BlobManager.js
Browse files Browse the repository at this point in the history
  • Loading branch information
janicduplessis authored Apr 29, 2019
1 parent cc62559 commit 92a9f02
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions Libraries/Blob/BlobManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,13 @@ function uuidv4(): string {
});
}

// **Temporary workaround**
// TODO(#24654): Use turbomodules for the Blob module.
// Blob collector is a jsi::HostObject that is used by native to know
// when the a Blob instance is deallocated. This allows to free the
// underlying native resources. This is a hack to workaround the fact
// that the current bridge infra doesn't allow to track js objects
// deallocation. Ideally this would use TurboModules and the whole Blob
// object should be a jsi::HostObject.
// deallocation. Ideally the whole Blob object should be a jsi::HostObject.
function createBlobCollector(blobId: string): BlobCollector | null {
if (global.__blobCollectorProvider == null) {
return null;
Expand Down

0 comments on commit 92a9f02

Please sign in to comment.