-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed setDefaults not being called in React Native apps, fixed typo
Reviewed By: javache Differential Revision: D3469296 fbshipit-source-id: 032472fede4bfbd051b0f725f35368b22edcc130
- Loading branch information
1 parent
8839b6d
commit 9f9c6a8
Showing
2 changed files
with
2 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9f9c6a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nathanajah Are you working on setting defaults in the constructor, or should I submit a PR? Just don't want to release 0.29 without the defaults being set to development mode.
9f9c6a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsierles I'm working on it. I have a diff up internally.
9f9c6a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nathanajah awesome, thanks for working on this - it's really a big change for the dev experience!