Adding support to float values for Android snapToInterval

Reviewed By: fkgozali Differential Revision: D6684529 fbshipit-source-id: 51efa0a2d38acf4134bb824c462973e5c6bdf17a
facebook · Jan 9, 2018 · b2848a5 · b2848a5
1 parent a8d4666
commit b2848a5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/RNTester/js/ScrollViewSimpleExample.js b/RNTester/js/ScrollViewSimpleExample.js
@@ -50,7 +50,7 @@ class ScrollViewSimpleExample extends React.Component<{}> {
       <ScrollView
         key={'scrollViewSnap'}
         horizontal
-        snapToInterval={210}
+        snapToInterval={210.0}
         pagingEnabled
       >
         {this.makeItems(NUM_ITEMS, [

diff --git a/...droid/src/main/java/com/facebook/react/views/scroll/ReactHorizontalScrollViewManager.java b/...droid/src/main/java/com/facebook/react/views/scroll/ReactHorizontalScrollViewManager.java
@@ -73,9 +73,10 @@ public void setShowsHorizontalScrollIndicator(ReactHorizontalScrollView view, bo
   }
 
   @ReactProp(name = "snapToInterval")
-  public void setSnapToInterval(ReactHorizontalScrollView view, int snapToInterval) {
+  public void setSnapToInterval(ReactHorizontalScrollView view, float snapToInterval) {
+    // snapToInterval needs to be exposed as a float because of the Javascript interface.
     DisplayMetrics screenDisplayMetrics = DisplayMetricsHolder.getScreenDisplayMetrics();
-    view.setSnapInterval((int)(snapToInterval * screenDisplayMetrics.density));
+    view.setSnapInterval((int) (snapToInterval * screenDisplayMetrics.density));
   }
 
   @ReactProp(name = ReactClippingViewGroupHelper.PROP_REMOVE_CLIPPED_SUBVIEWS)