Skip to content

Commit

Permalink
Make TurboModuleManager not implement JSIModule (#42060)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #42060

For removal of JSIModule getting rid of the inheritance relationship b/w interfaces TurboModuleManager & JSIModule by directly defining `invalidate()`. `initialize()` here isn't being used hence not defining it.

Changelog:
[Internal] internal

Reviewed By: philIip, mdvacca

Differential Revision: D49977957

fbshipit-source-id: 8de644b1f344d8ce8d4a78655556829f860a2b10
  • Loading branch information
arushikesarwani94 authored and facebook-github-bot committed Dec 28, 2023
1 parent d992abc commit b507e11
Showing 1 changed file with 1 addition and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
import com.facebook.jni.HybridData;
import com.facebook.proguard.annotations.DoNotStrip;
import com.facebook.react.bridge.CxxModuleWrapper;
import com.facebook.react.bridge.JSIModule;
import com.facebook.react.bridge.NativeModule;
import com.facebook.react.bridge.ReactNoCrashSoftException;
import com.facebook.react.bridge.ReactSoftExceptionLogger;
Expand All @@ -35,7 +34,7 @@
* has a C++ counterpart This class installs the JSI bindings. It also implements the method to get
* a Java module, that the C++ counterpart calls.
*/
public class TurboModuleManager implements JSIModule, TurboModuleRegistry {
public class TurboModuleManager implements TurboModuleRegistry {
private final List<String> mEagerInitModuleNames;
private final ModuleProvider mTurboModuleProvider;
private final ModuleProvider mLegacyModuleProvider;
Expand Down Expand Up @@ -432,9 +431,6 @@ private native HybridData initHybrid(
private native void installJSIBindings(
boolean shouldCreateLegacyModules, boolean enableSyncVoidMethods);

@Override
public void initialize() {}

@Override
public void invalidate() {
/*
Expand Down

0 comments on commit b507e11

Please sign in to comment.