Skip to content

Commit

Permalink
Revert faulty change to HelloWorld demo in docs
Browse files Browse the repository at this point in the history 
Summary:
Related to commit/diff:
6e99e31#diff-692279cda23c48738b9688454811448a

The above change breaks "HelloWorld" demo in docs, as you can see at the bottom of the below screenshot:
![image](https://user-images.githubusercontent.com/5363847/30427914-9477d4ee-9949-11e7-8be6-3d6990d6e267.png)

This pull request reverts things just enough to get the demo working correctly again.

I'm new to react-native so I'm not sure if there is another (read: better) solution but by accepting this pull request it would prevent noobs like myself from falling at the first hurdle!
Closes #15947

Differential Revision: D5866110

Pulled By: hramos

fbshipit-source-id: a453e4373b8af528e3ef2fa6a5a029ff398b0398
  • Loading branch information
@facebook-github-bot
Drew Smith authored and facebook-github-bot committed Sep 19, 2017
1 parent e99fbfc commit c25a3db
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion docs/Tutorial.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ In accordance with the ancient traditions of our people, we must first build an

```ReactNativeWebPlayer
import React, { Component } from 'react';
import { Text } from 'react-native';
import { AppRegistry, Text } from 'react-native';
export default class HelloWorldApp extends Component {
render() {
Expand All @@ -28,6 +28,9 @@ export default class HelloWorldApp extends Component {
);
}
}
// skip this line if using Create React Native App
AppRegistry.registerComponent('AwesomeProject', () => HelloWorldApp);
```

If you are feeling curious, you can play around with sample code directly in the web simulators. You can also paste it into your `App.js` file to create a real app on your local machine.
Expand Down

5 comments on commit c25a3db

@ChairmanMeow
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I agree. They should fix this bug lol. All the new people coming into the tutorials see that it is broken.

@a8t
Copy link

@a8t a8t commented on c25a3db Oct 29, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still broken on my end. The same lines are still missing. (Maybe I just don't know exactly how this repo connects to the actual site but yeah ¯\_(ツ)_/¯

@apieceofbart
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still broken, furthermore the error is trimmed: Invariant Violation: Application "App" has not been registered. This is either due

@bradiosd
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit does actually fix the issue but it has not been applied to the live docs website yet (I believe).

@monkpit
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only has this not been applied to the live docs, but the live docs that are linked to for version 0.50 still prominently display "0.49" in the site header...

Please sign in to comment.