Skip to content

Commit

Permalink
Fix clang warning for -Winconsistent-missing-destructor-override (#42942
Browse files Browse the repository at this point in the history
)

Summary:
Pull Request resolved: #42942

Instance derives from jsinspector_modern::InstanceTargetDelegate, which defines a virtual destructor, but Instance does not mark its destructor with override.

## Changelog [Internal]

Reviewed By: cipolleschi

Differential Revision: D53609922

fbshipit-source-id: b30df7d59478fa72b53ddc2eeb04c291a6f5f9eb
  • Loading branch information
rozele authored and facebook-github-bot committed Feb 9, 2024
1 parent f6f4615 commit cadaf26
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/cxxreact/Instance.h
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ struct InstanceCallback {

class RN_EXPORT Instance : private jsinspector_modern::InstanceTargetDelegate {
public:
~Instance();
~Instance() override;
void initializeBridge(
std::unique_ptr<InstanceCallback> callback,
std::shared_ptr<JSExecutorFactory> jsef,
Expand Down

0 comments on commit cadaf26

Please sign in to comment.