Skip to content

Commit

Permalink
Fix startListeningToAnimatedNodeValue in NativeAnimated batch mode
Browse files Browse the repository at this point in the history
Summary:
This op code was incorrectly configured to take two args, while it only takes one.

Changelog: [Internal]

Differential Revision: D36664590

fbshipit-source-id: 6e1fdb9f64bbd32fbe05bbd174f94ae57292bcf9
  • Loading branch information
javache authored and facebook-github-bot committed May 25, 2022
1 parent 26a5416 commit debc32b
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1047,6 +1047,7 @@ public void queueAndExecuteBatchedOperations(final ReadableArray opsAndArgs) {
BatchExecutionOpCodes command = BatchExecutionOpCodes.fromId(opsAndArgs.getInt(i++));
switch (command) {
case OP_CODE_GET_VALUE:
case OP_START_LISTENING_TO_ANIMATED_NODE_VALUE:
case OP_STOP_LISTENING_TO_ANIMATED_NODE_VALUE:
case OP_CODE_STOP_ANIMATION:
case OP_CODE_FLATTEN_ANIMATED_NODE_OFFSET:
Expand All @@ -1059,7 +1060,6 @@ public void queueAndExecuteBatchedOperations(final ReadableArray opsAndArgs) {
break;
case OP_CODE_CREATE_ANIMATED_NODE:
case OP_CODE_UPDATE_ANIMATED_NODE_CONFIG:
case OP_START_LISTENING_TO_ANIMATED_NODE_VALUE:
case OP_CODE_CONNECT_ANIMATED_NODES:
case OP_CODE_DISCONNECT_ANIMATED_NODES:
case OP_CODE_SET_ANIMATED_NODE_VALUE:
Expand Down Expand Up @@ -1115,7 +1115,6 @@ public void execute(NativeAnimatedNodesManager animatedNodesManager) {
break;
case OP_START_LISTENING_TO_ANIMATED_NODE_VALUE:
final int tag = opsAndArgs.getInt(i++);
final int value = opsAndArgs.getInt(i++);
final AnimatedNodeValueListener listener =
new AnimatedNodeValueListener() {
public void onValueUpdate(double value) {
Expand Down

0 comments on commit debc32b

Please sign in to comment.