Skip to content

Commit

Permalink
Disable failing tests (#20622)
Browse files Browse the repository at this point in the history
Summary:
`test_detox_end_to_end` and `test_objc_end_to_end` are both failing on master. This is polluting internal diffs that do not introduce failures.

As we just now started tracking Circle CI on our internal builds, I want to make sure we only nag internal diffs when the failure can actually be attributed to the diff. The failures in the e2e tests precede the Circle CI integration and are adding unnecessary noise.

Going forward, we will immediately go back to a diff and push the author to fix the broken CI, so this PR is a temporary fix.
Pull Request resolved: #20622

Differential Revision: D9272360

Pulled By: hramos

fbshipit-source-id: 2f8d22e35d301aa7eb67ed08f6deed21bf971acd
  • Loading branch information
hramos authored and facebook-github-bot committed Aug 10, 2018
1 parent 16b3783 commit e0465bf
Showing 1 changed file with 12 additions and 9 deletions.
21 changes: 12 additions & 9 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -467,6 +467,7 @@ jobs:
path: ~/react-native/reports/junit

# Runs end to end tests (Detox)
# Disabled.
test_detox_end_to_end:
<<: *macos_defaults
steps:
Expand Down Expand Up @@ -674,16 +675,18 @@ workflows:
requires:
- checkout_code

# Disabled on master.

# End-to-end tests
- test_objc_end_to_end:
filters: *filter-ignore-gh-pages
requires:
- checkout_code
# - test_objc_end_to_end:
# filters: *filter-ignore-gh-pages
# requires:
# - checkout_code

- test_detox_end_to_end:
filters: *filter-ignore-gh-pages
requires:
- checkout_code
# - test_detox_end_to_end:
# filters: *filter-ignore-gh-pages
# requires:
# - checkout_code


# Only runs on vX.X.X tags if all tests are green
Expand All @@ -698,7 +701,7 @@ workflows:
- test_javascript
- test_objc
- test_android
- test_objc_end_to_end
# - test_objc_end_to_end

# Only runs on PRs
analyze:
Expand Down

0 comments on commit e0465bf

Please sign in to comment.