Rename jSEngineInstance -> jsEngineInstance (#38909)

Summary: Pull Request resolved: #38909 Rename jSEngineInstance -> jsEngineInstance changelog: [internal] internal Reviewed By: christophpurrer Differential Revision: D48051751 fbshipit-source-id: ae96270f9dfa56b39bcc42ea8ac108235695311c
facebook · Aug 10, 2023 · e2ef6b9 · e2ef6b9
1 parent 2e5b122
commit e2ef6b9
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/...eact-native/ReactAndroid/src/main/java/com/facebook/react/bridgeless/ReactHostDelegate.kt b/...eact-native/ReactAndroid/src/main/java/com/facebook/react/bridgeless/ReactHostDelegate.kt
@@ -39,7 +39,7 @@ interface ReactHostDelegate {
   val reactPackages: List<ReactPackage>
 
   /** Object that holds a native reference to the javascript engine */
-  val jSEngineInstance: JSEngineInstance
+  val jsEngineInstance: JSEngineInstance
 
   /**
    * Bundle loader to use when setting up JS environment. <p>Example:
@@ -66,7 +66,7 @@ interface ReactHostDelegate {
   class ReactHostDelegateBase(
       override val jsMainModulePath: String,
       override val jSBundleLoader: JSBundleLoader,
-      override val jSEngineInstance: JSEngineInstance,
+      override val jsEngineInstance: JSEngineInstance,
       override val turboModuleManagerDelegateBuilder:
           ReactPackageTurboModuleManagerDelegate.Builder,
       override val reactPackages: List<ReactPackage> = emptyList(),

diff --git a/.../react-native/ReactAndroid/src/main/java/com/facebook/react/bridgeless/ReactInstance.java b/.../react-native/ReactAndroid/src/main/java/com/facebook/react/bridgeless/ReactInstance.java
@@ -165,7 +165,7 @@ public void onHostDestroy() {
           }
         });
 
-    JSEngineInstance jsEngineInstance = mDelegate.getJSEngineInstance();
+    JSEngineInstance jsEngineInstance = mDelegate.getJsEngineInstance();
     BindingsInstaller bindingsInstaller = mDelegate.getBindingsInstaller();
     // Notify JS if profiling is enabled
     boolean isProfiling =

diff --git a/...native/ReactAndroid/src/main/java/com/facebook/react/defaults/DefaultReactHostDelegate.kt b/...native/ReactAndroid/src/main/java/com/facebook/react/defaults/DefaultReactHostDelegate.kt
@@ -43,7 +43,7 @@ class DefaultReactHostDelegate(
     override val jsMainModulePath: String,
     override val jSBundleLoader: JSBundleLoader,
     override val reactPackages: List<ReactPackage> = emptyList(),
-    override val jSEngineInstance: JSEngineInstance = HermesInstance(),
+    override val jsEngineInstance: JSEngineInstance = HermesInstance(),
     override val bindingsInstaller: BindingsInstaller = DefaultBindingsInstaller(),
     private val reactNativeConfig: ReactNativeConfig = ReactNativeConfig.DEFAULT_CONFIG,
     private val exceptionHandler: (Exception) -> Unit = {},

diff --git a/...-native/ReactAndroid/src/test/java/com/facebook/react/bridgeless/ReactHostDelegateTest.kt b/...-native/ReactAndroid/src/test/java/com/facebook/react/bridgeless/ReactHostDelegateTest.kt
@@ -40,7 +40,7 @@ class ReactHostDelegateTest {
         DefaultReactHostDelegate(
             jsMainModulePath = jsMainModulePathMocked,
             jSBundleLoader = jsBundleLoader,
-            jSEngineInstance = hermesInstance,
+            jsEngineInstance = hermesInstance,
             turboModuleManagerDelegateBuilder = turboModuleManagerDelegateBuilderMock)
 
     assertThat(delegate.jsMainModulePath).isEqualTo(jsMainModulePathMocked)

diff --git a/...-tester/android/app/src/main/java/com/facebook/react/uiapp/RNTesterReactHostDelegate.java b/...-tester/android/app/src/main/java/com/facebook/react/uiapp/RNTesterReactHostDelegate.java
@@ -78,7 +78,7 @@ public ReactPackageTurboModuleManagerDelegate.Builder getTurboModuleManagerDeleg
   }
 
   @Override
-  public JSEngineInstance getJSEngineInstance() {
+  public JSEngineInstance getJsEngineInstance() {
     if (mReactHost.getJSEngineResolutionAlgorithm() == JSEngineResolutionAlgorithm.JSC) {
       return new JSCInstance();
     } else {