[Android]textinput:Maintain cursor position when secureTextEntry togg…

…les.
facebook · Feb 7, 2018 · e4c87d4 · uhoh2017 · Feb 7, 2018 · e4c87d4
1 parent d3db764
commit e4c87d4
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java b/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java
@@ -519,12 +519,10 @@ public void setMultiline(ReactEditText view, boolean multiline) {
 
   @ReactProp(name = "secureTextEntry", defaultBoolean = false)
   public void setSecureTextEntry(ReactEditText view, boolean password) {
-    updateStagedInputTypeFlag(
-        view,
-        password ? 0 :
-            InputType.TYPE_NUMBER_VARIATION_PASSWORD | InputType.TYPE_TEXT_VARIATION_PASSWORD,
-        password ? InputType.TYPE_TEXT_VARIATION_PASSWORD : 0);
+    int selectionStart = view.getSelectionStart();
+    view.setTransformationMethod(password ? new PasswordTransformationMethod() : null);
     checkPasswordType(view);
+    view.setSelection(selectionStart);
   }
 
   @ReactProp(name = "autoCapitalize")