Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples fail on linking step in linking with Pods-RCTNetworkImage #118

Closed
jaygarcia opened this issue Mar 3, 2015 · 7 comments
Closed
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@jaygarcia
Copy link
Contributor

Seems that with migrating things to cocoa pods, the examples are inoperable:

2015-03-03_08-55-55

2015-03-03_08-53-58_02

@jaygarcia
Copy link
Contributor Author

Strangely enough, UI Explorer at least runs -- it doesn't seem to be using pods =)

@vjeux
Copy link
Contributor

vjeux commented Mar 3, 2015

Woops. We don't have yet continuous integration on the open source examples and we are mostly testing on the explorer examples and not movies app. I'll send a fix later today.

Note that we're going to move away from cocoapods, this was an experiment but doesn't work out well in practice :(

@jaygarcia
Copy link
Contributor Author

fucking thank you! =)

I was going to get on a soapbox and explain how this was going to be problematic.

/me gets off soapbox

@joewood
Copy link

joewood commented Mar 3, 2015

Could somebody post a one sentence summary of what the problem would be? It seemed to be quite an elegant solution of packaging the native parts from npm. I struggle with Cordova's plugin model and the impact on the native build part.

@sahrens
Copy link
Contributor

sahrens commented Mar 3, 2015

I'm sure others can list more problems, but from my perspective, supporting CocoaPods as a first-class system has the following issues:

  1. Non-ideal project layout (copies files rather than linking projects, all libs are under Pods project)

  2. Allows excessive flexibility with build configurations that are hard to model in other dependency and build systems.

We will continue to support interoperability with cocoapods of you want to use them, but we're going to come up with something more universal that integrates better with npm as the recommended way to generate Xcode projects and workspaces.

On Mar 3, 2015, at 12:17 PM, Joe Wood notifications@github.com wrote:

Could somebody post a one sentence summary of what the problem would be? It seemed to be quite an elegant solution of packaging the native parts from npm. I struggle with Cordova's plugin model and the impact on the native build part.


Reply to this email directly or view it on GitHub.

@joewood
Copy link

joewood commented Mar 3, 2015

OK, sounds interesting. So the non-JS sources would be kept in npm, I guess something like node-gyp.

@sahrens
Copy link
Contributor

sahrens commented Mar 3, 2015

Yeah, we want npm to have all the code.

On Mar 3, 2015, at 12:57 PM, Joe Wood notifications@github.com wrote:

OK, sounds interesting. So the non-JS sources would be kept in npm, I guess something like node-gyp.


Reply to this email directly or view it on GitHub.

@facebook facebook locked as resolved and limited conversation to collaborators May 29, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 23, 2018
react-one pushed a commit to react-one/react-native that referenced this issue Sep 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

5 participants