Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ListView & Image] Loading 100 big images into a ListView not only crashes the app, but also crashes the os #1360

Closed
liangfenxiaodao opened this issue May 21, 2015 · 16 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@liangfenxiaodao
Copy link

I have a list of 100 image URLs and seeded them into the datasource of the ListView.

then I used this one for renderRow:

<Image source={{uri: imageUri}} style={styles.image} />

and it worked fine when I was scrolling the top 40~50 images, but when I scrolled to the end of the list, then the app crashed and I saw the white apple on the screen.

And there is no stacktrace in crash report.

@Iragne
Copy link
Contributor

Iragne commented May 26, 2015

it's cleary an issue with the size of the images.
It's a memory warning

@tadeuzagallo
Copy link
Contributor

Can you reproduce that constantly?

@Iragne
Copy link
Contributor

Iragne commented May 26, 2015

As soon as you load big image in a list you get this problem i will investigate more.
I solve in a way this issue on Library Asset #1406

@astrotars
Copy link

You could use preprocessing like http://6px.io
On Tue, May 26, 2015 at 8:52 AM Iragne notifications@github.com wrote:

As soon as you load big image in a list you get this problem i will
investigate more.
I solve in a way this issue on Library Asset #1406
#1406


Reply to this email directly or view it on GitHub
#1360 (comment)
.

@Iragne
Copy link
Contributor

Iragne commented May 26, 2015

yes if you want it will work.
But i think we should implement it in react

@astrotars
Copy link

Totally agree. I have an application that will be loading several hundred.
Would love to see a fix for this. +1.
On Tue, May 26, 2015 at 8:59 AM Iragne notifications@github.com wrote:

yes if you want it will work.
But i think we should implement it in react


Reply to this email directly or view it on GitHub
#1360 (comment)
.

@Iragne
Copy link
Contributor

Iragne commented May 26, 2015

+1

@Iragne
Copy link
Contributor

Iragne commented May 26, 2015

https://github.com/Iragne/UIImage-ResizeMagick ;) it's a good start !!!

@liangfenxiaodao
Copy link
Author

@tadeuzagallo Yes, I can reproduce it constantly

@KJlmfe
Copy link
Contributor

KJlmfe commented May 29, 2015

I also have this problem.

I implement this page http://www.tmall.com/wh/tmall/act/14242/jfbybk with react-native ListView component, when I run in IPad air(not Simulator), it crash when I scroll fast or scroll to the bottom.

@brentvatne
Copy link
Collaborator

@xiaodao @KJlmfe - can you link us to a public repo where we can see the bug in action? Thanks!

cc @tadeuzagallo

@brentvatne brentvatne changed the title loading 100 big images into a ListView not only crashes the app, but also crashes the os [ListView + Image] Loading 100 big images into a ListView not only crashes the app, but also crashes the os May 29, 2015
@brentvatne brentvatne changed the title [ListView + Image] Loading 100 big images into a ListView not only crashes the app, but also crashes the os [ListView & Image] Loading 100 big images into a ListView not only crashes the app, but also crashes the os May 29, 2015
@sahrens
Copy link
Contributor

sahrens commented Jun 15, 2015

I think the general fix is view recycling, but we might need to do Image caching differently as well.

@osdio
Copy link

osdio commented Jul 20, 2015

@sahrens How about the tabView?

@fishedee
Copy link

I hava a demo which has 100 rows in listview and about 5 big image(1024x768) in single row.when i scroll,it crash.hope you can help us , thank you very much

@udfalkso
Copy link

udfalkso commented Mar 9, 2016

@nparsons08 Stop that.

@mkonicek
Copy link
Contributor

Hi there! This issue is being closed because it has been inactive for a while.

But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/listview-image-loading-100-big-images-into-a-listview-not-only-crashes-the-app-but-also-crashes-the-os

ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub. GitHub issues have voting too, nevertheless
Product Pains has been very useful in highlighting the top bugs and feature requests:
https://productpains.com/product/react-native?tab=top

Also, if this issue is a bug, please consider sending a pull request with a fix.
We're a small team and rely on the community for bug fixes of issues that don't affect fb apps.

@facebook facebook locked as resolved and limited conversation to collaborators Jul 22, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests