-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ScrollView] Warning: ScrollView doesn't take rejection well - scrolls anyway #1501
Comments
Is it a vertical + horizontal combination or two ScrollViews scrolling on the same axis? |
I get this warning randomly even without nested ScrollViews. No clue what it means. |
Ohhh I'm also getting this warning don't know why 😞 |
I'm also getting this warning |
I'm getting this when scrolling vertically a ListView that's inside an horizontal ScrollView |
The same issue is posted here as well: #41 |
👍 |
I'm getting this issue when nesting a TextInput inside a ListView. When scrolling most of the time I don't get the warning, but when I start the scroll with the pointer (this is in the simulator, haven't tried on device yet) on the TextInput it gives me the warning. |
I am also seeing this issue. I have a custom 'swipe to delete' for the rows which has a horizontal swipe inside a vertical ListView. If I move up or down at all while this happens, it scrolls. Even with setting:
|
I get this issue with a |
one more here. I have two ListViews inside a Scroll (I'm using |
@magicismight The jump reason is than you should set this |
111 |
when put a props dynamic in the scrollview it happend |
+1 |
5 similar comments
+1 |
+1 |
+1 |
+1 |
+1 |
+1 |
👍 |
@MENQ is right, if you drag a scrollview by press and drag within a multiline textInput then you get the error |
We can probably apply the fix in 67bf0f1 to scrollviews as well. If you have a test case for this, please try it and send a PR. |
@javache I have tested this PR few days ago, I think that solve this problem, but not: |
I tried many methods to have nested ScrollView and avoid warning message but I just can't seems to find a correct way. So, until there is one, I just decided to comment out where the warning message gets called in node_modules/react-native/Libraries/Components/ScrollResponder.js (v 0.17.0) line 203.
|
I get this "ScrolView doesn't take rejection well" so, this is no warning this is with warning |
+1 |
Can someone provide a repo where this happens for @javache? Just create a small example and put it up on Github. Thanks! |
Sure, here you go: https://github.com/jblack10101/ReactNativeScrollviewWarning |
I don't want to add noise here, but I noticed I am seeing this issue on iOS if I have a Picker inside the ScrollView. I am guessing this is an issue with there being a scrollable component within this scrollView |
+1 and it's not just the warning. If you have a form rendered in a ScrollView, then when you try to move from one TextInput to the next by tapping, the warning fires, and the next field doesn't get focus. You have to tap twice. It makes forms very annoying to use. |
+1 |
4 similar comments
+1 |
+1 |
+1 |
+1 |
I notice that, if you put a ScorllView/TextInput in another ScrollVIew, the warning will appear. |
+1 |
2 similar comments
+1 |
+1 |
+1 |
@gre +1 |
Summary:I get this warning in cases when nothing went wrong. Not sure what I can do about the warning. I placed a few sliders in a ScrollView and everything works as expected, so the warning is very confusing. Lots of people have been hitting the warning and getting confused by it as well: - #1501 - https://productpains.com/post/react-native/scrollview-warning-scrollview-doesnt-take-rejection-well-scrolls-anyway (it's one of the [highest rated](https://productpains.com/product/react-native?tab=top) issues). Reviewed By: sahrens Differential Revision: D3138736 fb-gh-sync-id: 601b8dfc275a14dff6f17a7903c65bd8347a73e9 fbshipit-source-id: 601b8dfc275a14dff6f17a7903c65bd8347a73e9
Hey guys, I've just removed the warning :) Context: 5f77f15 Lots of people report something similar to this:
I completely agree and don't think the warning is very useful. I'm closing this issue (the warning won't show up anymore in 0.24 and above). Regarding the second part of the issue description:
Please report that separately (with a video!) and ideally send a pull request with a fix. |
Summary:I get this warning in cases when nothing went wrong. Not sure what I can do about the warning. I placed a few sliders in a ScrollView and everything works as expected, so the warning is very confusing. Lots of people have been hitting the warning and getting confused by it as well: - #1501 - https://productpains.com/post/react-native/scrollview-warning-scrollview-doesnt-take-rejection-well-scrolls-anyway (it's one of the [highest rated](https://productpains.com/product/react-native?tab=top) issues). Reviewed By: sahrens Differential Revision: D3138736 fb-gh-sync-id: 601b8dfc275a14dff6f17a7903c65bd8347a73e9 fbshipit-source-id: 601b8dfc275a14dff6f17a7903c65bd8347a73e9
To clarify, here's what the warning actually means. You can see I manage to scroll the ScrollView even when dragging the slider: This only happens on iOS and someone should fix that. But the warning pops up in many normal cases too, like when flinging the slider vertically. In this case scrolling is good but the warning still pops up. It's not clear to me whether this GitHub issue was about the warning itself or about the ScrollView not taking rejection well. The warning was not actionable and it is gone now, let's discuss the ScrollView not taking rejection well separately (ideally someone with iOS knowledge could send a pull request with a fix). |
@mkonicek Thanks, but did your commit get merged? I'm still getting the warning in 0.24 |
@mkonicek Same here, I'm still getting the warning in 0.24.1 |
@chirag04 not work. More details? |
Summary:I get this warning in cases when nothing went wrong. Not sure what I can do about the warning. I placed a few sliders in a ScrollView and everything works as expected, so the warning is very confusing. Lots of people have been hitting the warning and getting confused by it as well: - facebook#1501 - https://productpains.com/post/react-native/scrollview-warning-scrollview-doesnt-take-rejection-well-scrolls-anyway (it's one of the [highest rated](https://productpains.com/product/react-native?tab=top) issues). Reviewed By: sahrens Differential Revision: D3138736 fb-gh-sync-id: 601b8dfc275a14dff6f17a7903c65bd8347a73e9 fbshipit-source-id: 601b8dfc275a14dff6f17a7903c65bd8347a73e9
I put a ScrollView inside another ScrollView.
When I scrolled,It will give a warning:
Warning: ScrollView doesn't take rejection well - scrolls anyway
,and sometimes the ScrollView inside will jump to the top or bottom.The text was updated successfully, but these errors were encountered: