Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cosmetic] Rename tick to avoid iTunes Store warnings #1562

Closed
gpbl opened this issue Jun 8, 2015 · 7 comments
Closed

[Cosmetic] Rename tick to avoid iTunes Store warnings #1562

gpbl opened this issue Jun 8, 2015 · 7 comments
Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Resolution: Locked This issue was locked by the bot.

Comments

@gpbl
Copy link
Contributor

gpbl commented Jun 8, 2015

I'm using v0.5. Before submitting the app, when I validate an archive, I get this warning:

iTunes Store operation succeeded with a warning
The app references non public-selectors in Payload/<AppName>.app/<Appname>: tick:

Do you also get this message? Is it something I should worry about?
@vjeux
Copy link
Contributor

vjeux commented Jun 8, 2015

cc @nicklockwood

@nicklockwood
Copy link
Contributor

I don't think this should be a problem, as "tick:" is a pretty common name for timer handlers.

Thanks for letting us know though, I think we may want to change it just to avoid the noise.

(And of course, if your app does actually rejected for this, please do let us know).

@gpbl
Copy link
Contributor Author

gpbl commented Jun 8, 2015

Alright thanks! Such messages are a bit frightening because it's difficult to find out their actual meaning, especially using third-party libraries. Feel free to close the issue, if you don't need it as reminder.

@brentvatne
Copy link
Collaborator

I'm going to close this because otherwise it will just sit here, but a PR is very welcome to fix this 😄

@ide
Copy link
Contributor

ide commented Jun 11, 2015

How do people feel about s/tick/runTick/? Would make for an easy task.

@brentvatne
Copy link
Collaborator

@ide - maybe onTick? runTick is fine by me as well, no strong preference

@brentvatne brentvatne reopened this Jun 18, 2015
@brentvatne brentvatne changed the title iTunes store warning: the app references non-public selectors [Cosmetic] Rename tick to avoid iTunes Store warnings Jun 18, 2015
@brentvatne brentvatne added the Good first issue Interested in collaborating? Take a stab at fixing one of these issues. label Jun 18, 2015
@brentvatne brentvatne mentioned this issue Jun 18, 2015
Closed
@admmasters
Copy link
Contributor

Created a PR for this - changed tick to onTick.

a2 pushed a commit to a2/react-native that referenced this issue Jul 1, 2015
@admmasters
facebook#1562 Rename 'tick' to 'onTick' to pass iTunes Connect valida…
cf6ff3f 
…tion.

Summary:
Should close this issue and successfully pass iTunes Connect validation.
Closes facebook#1722
Github Author: Matt Revell <mattrevell82@me.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
@a2 a2 closed this as completed Jul 5, 2015
@facebook facebook locked as resolved and limited conversation to collaborators Jul 5, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@brentvatne @gpbl @vjeux @a2 @admmasters @ide @nicklockwood @react-native-bot