Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The scrollview breaks on iOS 10 when using RN-0.48 #15957

Closed
gameboyVito opened this issue Sep 15, 2017 · 9 comments
Closed

The scrollview breaks on iOS 10 when using RN-0.48 #15957

gameboyVito opened this issue Sep 15, 2017 · 9 comments
Labels
Issue: Author Provided Repro This issue can be reproduced in Snack or an attached project. Platform: iOS iOS applications. Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@gameboyVito
Copy link

Error:

Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[RCTCustomScrollView setContentInsetAdjustmentBehavior:]: unrecognized selector sent to instance 0x7ffab9891a00'

Reproduce:

Build your app by XCode9-GM, then run it on your iOS10 device or below version.

Env:

  • Device - iOS 10.3.1
  • XCode 9.0 (9A235)
  • react-native - 0.48.3
@janicduplessis
Copy link
Contributor

@skevy Any idea what could cause this? All calls seem to be wrapped with [_scrollView respondsToSelector:@selector(setContentInsetAdjustmentBehavior:)]

@janicduplessis janicduplessis added Issue: Author Provided Repro This issue can be reproduced in Snack or an attached project. Platform: iOS iOS applications. labels Sep 15, 2017
@gameboyVito
Copy link
Author

gameboyVito commented Sep 18, 2017

I think this commit 6e28b39 breaks the code. Any update?

@suetming
Copy link

I met the same problem. Any update?

@wannabehero
Copy link

The issue is in https://github.com/wix/react-native-navigation

You can fix it yourself. Just find RCCViewController.m and change this line to the following:

if ([view isKindOfClass:UIScrollView.class] && [view respondsToSelector:@selector(setContentInsetAdjustmentBehavior:)]) {

@baijunjie
Copy link

At present 1.1.228 version still has this problem, spronin method is very effective, hope the official can be repaired again.

@manishoo
Copy link

any updates on this ?! this is a critical issue I believe

@ide
Copy link
Contributor

ide commented Sep 25, 2017

Can you please point out which call is failing? Reading this thread, janic's pointed out that all of the RN call sites should be guarded and spronin mentioned this isn't even an issue with RN at all.

@gameboyVito
Copy link
Author

I think the latest react-native-navigation@1.1.229 has merged my PR and addressed this issue.

@stale
Copy link

stale bot commented Nov 24, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Nov 24, 2017
@stale stale bot closed this as completed Dec 1, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Dec 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Issue: Author Provided Repro This issue can be reproduced in Snack or an attached project. Platform: iOS iOS applications. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

7 participants