-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The scrollview breaks on iOS 10 when using RN-0.48 #15957
Comments
@skevy Any idea what could cause this? All calls seem to be wrapped with |
I think this commit 6e28b39 breaks the code. Any update? |
I met the same problem. Any update? |
The issue is in https://github.com/wix/react-native-navigation You can fix it yourself. Just find if ([view isKindOfClass:UIScrollView.class] && [view respondsToSelector:@selector(setContentInsetAdjustmentBehavior:)]) { |
At present 1.1.228 version still has this problem, spronin method is very effective, hope the official can be repaired again. |
any updates on this ?! this is a critical issue I believe |
Can you please point out which call is failing? Reading this thread, janic's pointed out that all of the RN call sites should be guarded and spronin mentioned this isn't even an issue with RN at all. |
I think the latest react-native-navigation@1.1.229 has merged my PR and addressed this issue. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions. |
Error:
Reproduce:
Build your app by XCode9-GM, then run it on your iOS10 device or below version.
Env:
Device - iOS 10.3.1
XCode 9.0 (9A235)
react-native - 0.48.3
The text was updated successfully, but these errors were encountered: