Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS11 safeArea effects on scrollView #1858

Closed
gran33 opened this issue Sep 14, 2017 · 6 comments
Closed

Fix iOS11 safeArea effects on scrollView #1858

gran33 opened this issue Sep 14, 2017 · 6 comments
Assignees

Comments

@gran33
Copy link
Contributor

gran33 commented Sep 14, 2017

Issue Description

There is a margin under the top bar that shouldn't be there.
Related to iOS11 and react-native issue:
facebook/react-native#15681

Steps to Reproduce / Code Snippets / Screenshots

Running any app with screen contains any scroll view, when push then pop, the back screen comes from the bottom.


Environment

  • React Native Navigation version: 1.1.85
  • React Native version: 0.45.1
  • Platform(s) (iOS, Android, or both?): iOS
  • Device info (Simulator/Device? OS version? Debug/Release?): Simulator + real device
@gran33 gran33 self-assigned this Sep 14, 2017
gran33 pushed a commit that referenced this issue Sep 14, 2017
gran33 added a commit that referenced this issue Sep 14, 2017
@gran33
Copy link
Contributor Author

gran33 commented Sep 14, 2017

fixed in #1859

@gran33 gran33 closed this as completed Sep 14, 2017
@DanielZlotin DanielZlotin reopened this Sep 14, 2017
@DanielZlotin
Copy link
Contributor

implement in v2

@gameboyVito
Copy link
Contributor

it's not working on iOS10 while building with Xcode9, though it works on iOS11. See this: facebook/react-native#15957

@gameboyVito
Copy link
Contributor

gameboyVito commented Sep 20, 2017

@gran33 @DanielZlotin
Fixed, I will send you a PR if you don't mind.
Please check #1896

junedomingo pushed a commit to junedomingo/react-native-navigation that referenced this issue Sep 29, 2017
@DanielZlotin
Copy link
Contributor

DanielZlotin commented Jan 15, 2018

So the current solution is a bug. This forces the users to specify magic numbers in their code, instead of letting the system do it's thing.

@LeoNatan
Copy link
Contributor

Fixed in v2. Will back-port to v1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants