-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android Websocket sends incorrect origin header #16304
Labels
Stale
There has been a lack of activity on this issue and it may be closed soon.
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions. |
stale
bot
added
the
Stale
There has been a lack of activity on this issue and it may be closed soon.
label
Dec 10, 2017
facebook-github-bot
pushed a commit
that referenced
this issue
Dec 7, 2018
) Summary: Fixes #16304 The standard format for origin HTTP headers does not allow a trailing slash. In order to not get warnings when connecting a websocket, I removed the trailing slash when generating the default origin HTTP header for the websocket connect request. Release Notes: ---------- [Android] [Fixed] - Fixed default origin header for websocket connections to match the standard format (https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Origin) in WebSocketModule Pull Request resolved: #22290 Differential Revision: D13374345 Pulled By: cpojer fbshipit-source-id: 1173241f2b6912fd6df5e196053a950bb42ff01b
kelset
pushed a commit
that referenced
this issue
Dec 12, 2018
) Summary: Fixes #16304 The standard format for origin HTTP headers does not allow a trailing slash. In order to not get warnings when connecting a websocket, I removed the trailing slash when generating the default origin HTTP header for the websocket connect request. Release Notes: ---------- [Android] [Fixed] - Fixed default origin header for websocket connections to match the standard format (https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Origin) in WebSocketModule Pull Request resolved: #22290 Differential Revision: D13374345 Pulled By: cpojer fbshipit-source-id: 1173241f2b6912fd6df5e196053a950bb42ff01b
grabbou
pushed a commit
that referenced
this issue
Dec 17, 2018
) Summary: Fixes #16304 The standard format for origin HTTP headers does not allow a trailing slash. In order to not get warnings when connecting a websocket, I removed the trailing slash when generating the default origin HTTP header for the websocket connect request. Release Notes: ---------- [Android] [Fixed] - Fixed default origin header for websocket connections to match the standard format (https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Origin) in WebSocketModule Pull Request resolved: #22290 Differential Revision: D13374345 Pulled By: cpojer fbshipit-source-id: 1173241f2b6912fd6df5e196053a950bb42ff01b
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this issue
Jun 17, 2019
…ebook#22290) Summary: Fixes facebook#16304 The standard format for origin HTTP headers does not allow a trailing slash. In order to not get warnings when connecting a websocket, I removed the trailing slash when generating the default origin HTTP header for the websocket connect request. Release Notes: ---------- [Android] [Fixed] - Fixed default origin header for websocket connections to match the standard format (https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Origin) in WebSocketModule Pull Request resolved: facebook#22290 Differential Revision: D13374345 Pulled By: cpojer fbshipit-source-id: 1173241f2b6912fd6df5e196053a950bb42ff01b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Is this a bug report?
Yes
Have you read the Contributing Guidelines?
Yes
Environment
Environment:
OS: Linux 4.10
Node: 8.3.0
Yarn: 1.1.0
npm: 5.3.0
Watchman: Not Found
Error: unable to print environment info
{ Error: not found: xcodebuild
at getNotFoundError (/home/alebedev/code/sandbox/MyOfficeSandbox/node_modules/which/which.js:13:12)
at Function.whichSync [as sync] (/home/alebedev/code/sandbox/MyOfficeSandbox/node_modules/which/which.js:134:9)
at getXcodeVersion (/home/alebedev/code/sandbox/MyOfficeSandbox/node_modules/envinfo/envinfo.js:17:25)
at Object.module.exports.print (/home/alebedev/code/sandbox/MyOfficeSandbox/node_modules/envinfo/envinfo.js:136:28)
at Object.info (/home/alebedev/code/sandbox/MyOfficeSandbox/node_modules/react-native/local-cli/info/info.js:17:13)
at Promise.resolve.then (/home/alebedev/code/sandbox/MyOfficeSandbox/node_modules/react-native/local-cli/cliEntry.js:109:26)
at
at process._tickCallback (internal/process/next_tick.js:188:7)
at Function.Module.runMain (module.js:611:11)
at startup (bootstrap_node.js:158:16) code: 'ENOENT' }
Steps to Reproduce
Expected Behavior
Origin value should not contain trailing slash
The text was updated successfully, but these errors were encountered: