[0.53] Commits to cherry-pick into stable release

[grabbou]

The thread containing issues that are blocking the 0.53 release and need to be addressed.

Please keep this list to critical bug fixes that are new in 0.53 and ideally have been merged into master -- post commit hashes rather than issue/PR numbers unless the issue/PR in question targets a problem specific to 0.53. The intent of these cherry-pick threads is not to solicit features but to fix things that make 0.53 substantially more launch-blocked than 0.52.

[ide]

Cherry-picked 8b64907 (fix HMR client message) for CRNA
29f8354 (fix CORS issue with xip.io)

[Andreyco]

Unify boost vs boost-for-react-native dependency, commit here d40db3a
Greatly improves build times.

[vonovak]

this is a bugfix for a RefreshControl issue introduced in 0.51 (or 0.52?), would be nice to have it fixed already in 0.53: ed5872e

[ide]

Cherry-picked in the RN Boost and RefreshControl commits. The Yoga commit does not merge cleanly and affects code that landed after 0.53 was cut.

[grabbou]

Just FYI, I'll be releasing stable version tomorrow in case you have any remaining commits to cherry pick.

…

On Wed, 31 Jan 2018 at 16:05 James Ide ***@***.***> wrote: Cherry-picked in the RN Boost and RefreshControl commits. The Yoga commit does not merge cleanly and affects code that landed after 0.53 was cut. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#17520 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACWcxuhBUcFB9Kq7qklLTvFORagUKylpks5tQIFQgaJpZM4RZXBj> .

[ide]

@grabbou I think that’s everything for now in 0.53-stable.

[brunolemos]

Is there a thread for non critical commits?

---

Context: The PR #16933 got merged to master (2-line change), but the import was messed up and deleted the whole file (0d4ff1b) and then it was recreated in another commit (b8c86b8) which does include the PR mentioned but can easily go unnoticed, so that's why I'm mentioning it here.

[grabbou]

No, we don't @brunolemos. Best to just let me know around the end / beginning of a month when I am about to release a new version.

[grabbou]

Meanwhile, let me close this issue as I am promoting 0.53 to stable.

[jozan]

I found one bug and fixed it in local-cli. It prevents us from upgrading since it breaks running on actual iOS device. I was directed to try pinging this thread in hopes to get patch release.

PR in question: #17983

[jozan]

Commit: f8fee0a

Sorry for ugly description, I don’t know how all this works...

[MrLoh]

It’s very unfortunate that 0.53 was release while not being stable. Without being able to run on device this is not very usable.

[jozan]

It’s is unfortunate but not unheard of and definitely not end of the world. Bug are part of software anyways. Creating a fork is regular procedure and in some cases even necessary. 0.53 is really great update with lots of other fixes. It didn’t work for us out of the box but it’s too big of a deal.

…

On Fri, 16 Feb 2018 at 12.09, Tobias Lohse ***@***.***> wrote: It’s very unfortunate that 0.53 was release while not being stable. Without being able to run on device this is not very usable. Sent with GitHawk <http://githawk.com> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#17520 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAXsqYjH6N1MFyXDVGFaWxgZQgJLaqLPks5tVVPpgaJpZM4RZXBj> .

[MrLoh]

Yeah I really appreciate the effort of all the people on making React native work. And 0.53 is a great release. And of course bugs always happen. Developing react native for around 6 months now, I’m just sometimes really frustrated how unstable everything still is (of course it’s beta) but It’s such a popular option for production apps. Whenever I do some web development now I’m amazed by how incredibly stable things are in comparison. Obviously the task for React native is monumental and it will probably take years to reach a similar level of maturity as web development. So everyone who is working towards that has my huge appreciation, it’s sometimes just hard to cope with the frustration of spending many hours again on just getting things to work. I have no idea how to improve this either, I guess we just all have to help where we can and bring a lot more patience and appreciation for the complexity of the problem that react native solves.

_{Sent with GitHawk}

[grabbou]

Thank you @MrLoh and @jozan for taking your time to share your thoughts on the latest stable release. I appreciate your feedback. I have cherry-picked this small fix to unblock you from upgrading. Should be out on npm within next couple of hours.

I agree that React Native has its unstable moments from time to time, but as others successfully pointed out, it is still a fairly new technology. The biggest problem with releases being sometimes prematurely promoted to stable is that the amount of people running on RC channel is limited. That makes it hard to spot problems before hitting stable channel.

We are doing our best to make that as pleasant experience as possible by controlling post-release state of issues and coordinating with Facebook the release status.

[MrLoh]

@grabbou thank you so much for making this release!! We are very grateful for all the hard work that you and so many others put into React Native. RN is a truly amazing technology solving a really hard problem and having a big impact on App development.