Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React-native 0.56] [Toggle Inspector] renderer.getInspectorDataForViewTag is not a function #21065

Closed
3 tasks done
TranLuongTuanAnh opened this issue Sep 12, 2018 · 8 comments
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.

Comments

@TranLuongTuanAnh
Copy link
Contributor

TranLuongTuanAnh commented Sep 12, 2018

Environment

React Native Environment Info:
    System:
      OS: macOS Sierra 10.12.6
      CPU: x64 Intel(R) Core(TM) i7-4771 CPU @ 3.50GHz
      Memory: 613.02 MB / 32.00 GB
      Shell: 3.2.57 - /bin/bash
    Binaries:
      Node: 9.1.0 - ~/.nvm/versions/node/v9.1.0/bin/node
      npm: 5.5.1 - ~/.nvm/versions/node/v9.1.0/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 11.2, macOS 10.13, tvOS 11.2, watchOS 4.2
      Android SDK:
        Build Tools: 23.0.1, 23.0.2, 23.0.3, 26.0.0, 26.0.1, 26.0.2, 26.0.3, 27.0.0, 27.0.1, 27.0.2, 27.0.3
        API Levels: 23, 25, 26, 27
    IDEs:
      Android Studio: 3.1 AI-173.4697961
      Xcode: 9.2/9C40b - /usr/bin/xcodebuild
    npmPackages:
      react: ^16.4.1 => 16.4.2
      react-native: ^0.56.0 => 0.56.0
    npmGlobalPackages:
      create-react-native-app: 1.0.0
      react-native-git-upgrade: 0.2.7

Description

After upgrate RN to 0.56, I'm try Toggle Inspector but that below error occur when I click anywhere in screen
simulator screen shot - iphone 7 - 2018-09-12 at 17 35 21

@TranLuongTuanAnh TranLuongTuanAnh changed the title [ React-native 0.56 ] [ Toggle Inspector ] renderer.getInspectorDataForViewTag is not a function [React-native 0.56] [Toggle Inspector] renderer.getInspectorDataForViewTag is not a function Sep 12, 2018
@react-native-bot
Copy link
Collaborator

It looks like you are using an older version of React Native. Please update to the latest release, v0.57 and verify if the issue still exists.

The ":rewind:Old Version" label will be removed automatically once you edit your original post with the results of running react-native info on a project using the latest release.

@jeffmwells
Copy link

Can confirm that upgrading to 0.57.0 of just the react-native package.json dependency did not fix the issue.

@react-native-bot
Copy link
Collaborator

I am closing this issue because it does not appear to have been verified on the latest release, and there has been no followup in a while.

If you found this thread after encountering the same issue in the latest release, please feel free to create a new issue with up-to-date information by clicking here.

@react-native-bot react-native-bot added the Ran Commands One of our bots successfully processed a command. label Oct 3, 2018
@jeffmwells
Copy link

Found out the solution to this problem for us. We had a library, react-metrics, from which we imported a single named export. Turns out the lib goes ahead and enables screen tracking (taps, gestures) metrics for you even if you don't import those other functions. So we did a deep import e.g. import blah from react-metrics/some/sub/folder and this resolved the issue.

@GuoguoDad
Copy link

Found out the solution to this problem for us. We had a library, react-metrics, from which we imported a single named export. Turns out the lib goes ahead and enables screen tracking (taps, gestures) metrics for you even if you don't import those other functions. So we did a deep import e.g. import blah from react-metrics/some/sub/folder and this resolved the issue.

could you code here ?

@TranLuongTuanAnh
Copy link
Contributor Author

@CxxyLucifer
My solution is here: https://github.com/facebook/react-native/pull/21237/files

@GuoguoDad
Copy link

@CxxyLucifer
My solution is here: https://github.com/facebook/react-native/pull/21237/files

3Q, nice

@cpojer
Copy link
Contributor

cpojer commented Jan 28, 2019

I'll land the attached PR to fix this issue.

facebook-github-bot pushed a commit that referenced this issue Jan 28, 2019
Summary:
Fix renderer.getInspectorDataForViewTag is not a function when try Toggle Inspector

Fixes #21065

Release Notes:
--------------
[BUGFIX] [MINOR] [/react-native/Libraries/Inspector/Inspector.js]
Pull Request resolved: #21237

Differential Revision: D13838339

Pulled By: cpojer

fbshipit-source-id: 363a4beba211e7868395578c7941cbda119bc753
matt-oakes pushed a commit to matt-oakes/react-native that referenced this issue Feb 7, 2019
…facebook#21237)

Summary:
Fix renderer.getInspectorDataForViewTag is not a function when try Toggle Inspector

Fixes facebook#21065

Release Notes:
--------------
[BUGFIX] [MINOR] [/react-native/Libraries/Inspector/Inspector.js]
Pull Request resolved: facebook#21237

Differential Revision: D13838339

Pulled By: cpojer

fbshipit-source-id: 363a4beba211e7868395578c7941cbda119bc753
@facebook facebook locked as resolved and limited conversation to collaborators Oct 3, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

5 participants