Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-native start not using passed --sourceExts #21854

Closed
elyalvarado opened this issue Oct 18, 2018 · 1 comment
Closed

react-native start not using passed --sourceExts #21854

elyalvarado opened this issue Oct 18, 2018 · 1 comment
Labels
Resolution: Locked This issue was locked by the bot. Tech: Bundler 📦 This issue is related to the bundler (Metro, Haul, etc) used.

Comments

@elyalvarado
Copy link
Contributor

Environment

React Native Environment Info:
System:
OS: macOS High Sierra 10.13.6
CPU: x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
Memory: 32.02 MB / 16.00 GB
Shell: 5.3 - /bin/zsh
Binaries:
Node: 8.12.0 - ~/.nvm/versions/node/v8.12.0/bin/node
Yarn: 1.10.1 - /usr/local/bin/yarn
npm: 6.4.1 - ~/.nvm/versions/node/v8.12.0/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 11.4, macOS 10.13, tvOS 11.4, watchOS 4.3
Android SDK:
Build Tools: 27.0.3
API Levels: 27
IDEs:
Android Studio: 3.1 AI-173.4907809
Xcode: 9.4.1/9F2000 - /usr/bin/xcodebuild
npmPackages:
react: 16.5.0 => 16.5.0
react-native: 0.57.0 => 0.57.0

Also tested with the latest react-native version (0.57.3)

Description

When starting the react-native packager either by using react-native start --sourceExts e2e.js, or by directly calling the local-cli included with the react-native package in node_modules the packager is not prioritizing the passed source extension.

Reproducible Demo

react-native init TestProject
cd TestProject
cp App.js App.e2e.js
# Make a visible change in App.e2e.js
react-native start --sourceExts e2e.js
react-native run-ios
# Check to see that the packager is not taking the e2e.js file
elyalvarado added a commit to elyalvarado/react-native that referenced this issue Oct 18, 2018
Fixes react-native start not using passed --sourceExts facebook#21854
elyalvarado added a commit to elyalvarado/react-native that referenced this issue Oct 18, 2018
Fixes react-native start not using passed --sourceExts facebook#21854
facebook-github-bot pushed a commit that referenced this issue Oct 30, 2018
)

Summary:
Fixes react-native start not using passed --sourceExts #21854
Pull Request resolved: #21855

Differential Revision: D12840358

Pulled By: rafeca

fbshipit-source-id: 4ee09341b5128d83274a39d8d01c13749efaa78b
@kelset kelset added 💻CLI Tech: Bundler 📦 This issue is related to the bundler (Metro, Haul, etc) used. labels Dec 17, 2018
@hramos
Copy link
Contributor

hramos commented Jan 14, 2019

The command line tools have their own repository and issue tracker over at https://github.com/react-native-community/react-native-cli.

@hramos hramos closed this as completed Jan 14, 2019
t-nanava pushed a commit to microsoft/react-native-macos that referenced this issue Jun 17, 2019
…ebook#21855)

Summary:
Fixes react-native start not using passed --sourceExts facebook#21854
Pull Request resolved: facebook#21855

Differential Revision: D12840358

Pulled By: rafeca

fbshipit-source-id: 4ee09341b5128d83274a39d8d01c13749efaa78b
@facebook facebook locked as resolved and limited conversation to collaborators Jan 14, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot. Tech: Bundler 📦 This issue is related to the bundler (Metro, Haul, etc) used.
Projects
None yet
Development

No branches or pull requests

4 participants