-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[React Fabric] Updating Build Configuration (CocoaPods, .xcodeproj, gradle) #22989
Comments
Hey there! I'd like to help, so I started with the podspec, and I'd appreciate any tips, on how to test and make sure everything is working. Thanks. |
First step is to have RNTester podspec able to build Fabric specs (that includes all subspecs from fabric directory). The next step after that is to actually use Fabric in RNTester. This is still work in progress for our team, so we can tackle that slightly later. cc @shergin |
Hey, could you guys please verify if this include is correct? I'm getting an error 'Unknown type name 'CGFloat'' in this file and looking at the code '<CoreGraphics/CoreGraphics.h>' is always used with .m files and import instead of include and .cpp files. |
Does it work if you modify it to If moving to react-native/ReactCommon/fabric/imagemanager/platform/ios/RCTImagePrimitivesConversions.h Line 8 in 94d49e5
|
@fkgozali are there any question marks you see as far as using CocoaPods with Fabric/TurboModules? I'd love to hear more about your experience so far. |
I can take a look at updating the xcodeproj files. |
We don't use cocoapods/gradle internally, so I'm hoping the unknowns can be covered with the help from community on this issue. |
Hey |
I switched gears to updating the podspec (xcodeprojs are a pain). Here is what I have so far: mgriepentrog@44c5649. To find a lot of the low-hanging fruit, I'm running |
I got stuck on the same problem, and couldn't get pass it I added same frameworks, changed some files and then same problem again. 😟 |
It looks like this header file wasn't included in your setup?
|
I made progress on getting the cocoapods to build and ran in to a few problems:
I am still working on getting it to build a little further, and and still trying to figure out what is going on with Float.h. But the podfile seems mostly complete: ericlewis@a6510d9. It creates libReact.a. |
One thing I noticed, if you look at the Pods project under the |
I updated those frameworks manually to point to 12.1 & was no dice. |
Here is my WIP: https://github.com/ericlewis/react-native/commits/fabric
Compiling this branch's RNTester with RCTFabric & RCTFabricSample works, it links correctly! But you must remove the fabric switch component refs, bc they ref something called |
Another issue too is I get a “functional file not found” in relation to what looks like libc++ headers in LayoutPrimitives.h, it also happens in SurfacePresenter with memory, tho that is fixed by a rename to memory.h. I have not been able to figure out why this is happening, tho it is not happening in older versions of fabric using this same technique. |
cc @shergin, @JoshuaGross -- thoughts? |
@fkgozali I figured out what the issue was.. I am not sure I am using the library correctly, it happened when importing |
My current progress, open issues, and questions: #23550 |
Ah, yeah a bunch of files need to become .mm instead. I think that's an ok requirement though, given the increasing number of C++ we're adding. That said, if AppDelegate.m needs to be AppDelegate.mm, let's switch it over. If you find more .m files to be converted to .mm, let's note them here as well. |
Working podspecs: #23802 |
RNTester now works with Fabric, and we have a separate issue dealing with folly so I'm gonna go ahead and close this issue. @fkgozali feel free to reopen or create a new issue depending on whether you wanted to keep this issue as a meta issue for all Fabric work or just scoped to making things work in RNTester. |
Hold on, this is the umbrella ask for fabric build, including android, so let's keep this open. What was done was just for CocoaPods. |
Also what's not yet done:
|
@fkgozali should we close this off? :D |
yes this is an old issue
On Jun 18, 2021, at 4:16 AM, Lorenzo Sciandra ***@***.***> wrote:
@fkgozali<https://github.com/fkgozali> should we close this off? :D
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#22989 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAILROXV2YIAUZ4FJCHRSC3TTMTJJANCNFSM4GQAKN6A>.
|
For Discussion
Various parts of React Fabric code are available in github, but we need to upgrade a bunch of build configuration to make it build properly on iOS and Android. This will involve reflecting the BUCK targets for various parts of Fabric into the 3 areas:
An initial version of the update could just be manually sync'ed configs for .podspec, .xcodeproj, and .gradle.
But for the future, some ideas include:
buck project
Requirements
cc @mdvacca, @shergin
The text was updated successfully, but these errors were encountered: