Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug with react-native link in android and windows #23176

Closed
misaku opened this issue Jan 27, 2019 · 3 comments
Closed

bug with react-native link in android and windows #23176

misaku opened this issue Jan 27, 2019 · 3 comments
Labels
Bug Platform: Android Android applications. Resolution: Locked This issue was locked by the bot.

Comments

@misaku
Copy link
Contributor

misaku commented Jan 27, 2019

Environment

React Native Environment Info:
System:
OS: Windows 10
CPU: (8) x64 Intel(R) Core(TM) i7-4770K CPU @ 3.50GHz
Memory: 2.66 GB / 15.89 GB
Binaries:
Yarn: 1.13.0 - ~\AppData\Roaming\npm\yarn.CMD
npm: 6.5.0 - C:\Program Files\nodejs\npm.CMD
Watchman: 4.9.4 - D:\servers\watchman\watchman.EXE
IDEs:
Android Studio: Version 3.3.0.0 AI-182.5107.16.33.5199772

Description

When run react-native link in windows and android
the url use \ and not /
for example:
project(':react-native-gesture-handler').projectDir = new File(rootProject.projectDir, '..\node_modules\react-native-gesture-handler\android')
and to fix to:
project(':react-native-gesture-handler').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-gesture-handler/android')

Reproducible Demo

react-native link in windows

@misaku
Copy link
Contributor Author

misaku commented Jan 27, 2019

i will try to find and when ai fix i will submit pull request

@misaku misaku changed the title bug withe react-native link in android and windows bug with react-native link in android and windows Jan 27, 2019
@kelset
Copy link
Contributor

kelset commented Jan 28, 2019

That's a good idea, but maybe it's worth working directly with https://github.com/react-native-community/react-native-cli which is the new place where the CLI will be hosted in the future 👍

misaku added a commit to misaku/react-native-cli that referenced this issue Jan 28, 2019
Fix for Windows Backslashes is the escape character and will result in an invalid path in settings.gradle
  [issue:23176]( facebook/react-native#23176)
  i found this fix in past commit (0.57) and i submit again.

Changelog:
----------

[Android] [Fixed] - Fix for Windows Backslashes is the escape character and will result in an invalid path in settings.gradle

Test Plan:
----------

in windows run react-native link and start error,  Backslashes is the escape character and will result in an invalid path in settings.gradle
@misaku misaku closed this as completed Jan 28, 2019
@alainib
Copy link

alainib commented Mar 7, 2019

same error for me

@facebook facebook locked as resolved and limited conversation to collaborators Jan 28, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Platform: Android Android applications. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants